Skip to content

Fixing the missing sources and javadoc Maven artifacts #25660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fixing the missing sources and javadoc Maven artifacts #25660

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d58203
Fixing the missing sources and javadoc Maven artifacts
Ariho-Seth Aug 6, 2025
906d23e
Revert "Fixing the missing sources and javadoc Maven artifacts"
Ariho-Seth Aug 7, 2025
df92c6c
Fixing the missing sources and javadoc Maven artifacts
Ariho-Seth Aug 7, 2025
4caef11
Replaced old maven-javadoc-plugin versions to new ones
Ariho-Seth Aug 7, 2025
f4c83d2
Replaced maven-plugin reference versions with real values
Ariho-Seth Aug 7, 2025
eb4f295
Removed overridden version values
Ariho-Seth Aug 7, 2025
0f7bc65
Merge branch 'eclipse-ee4j:master' into MavenArtifacts
Ariho-Seth Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions appserver/distributions/glassfish/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
<glassfish.modules>${project.build.directory}/stage/glassfish7/glassfish/modules</glassfish.modules>
<glassfish.appclient>${project.build.directory}/stage/glassfish7/glassfish/lib/appclient</glassfish.appclient>
<patches>${basedir}/src/main/patches</patches>
<maven-javadoc-plugin.version>3.8.0</maven-javadoc-plugin.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -70,6 +71,23 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadoc</id>
<goals>
<goal>jar</goal>
</goals>
<phase>package</phase>
<configuration>
<includeTransitiveDependencySources>true</includeTransitiveDependencySources>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
Expand Down
18 changes: 18 additions & 0 deletions appserver/distributions/web/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<properties>
<glassfish.modules>${project.build.directory}/stage/glassfish7/glassfish/modules</glassfish.modules>
<patches>${basedir}/src/main/patches</patches>
<maven-javadoc-plugin.version>3.8.0</maven-javadoc-plugin.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -75,6 +76,23 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadoc</id>
<goals>
<goal>jar</goal>
</goals>
<phase>package</phase>
<configuration>
<includeTransitiveDependencySources>true</includeTransitiveDependencySources>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
Expand Down
47 changes: 45 additions & 2 deletions appserver/extras/embedded/all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
<artifact-collection.directory>${project.build.directory}/jars</artifact-collection.directory>
<rar.directory>${project.build.directory}/rars</rar.directory>
<maven-javadoc-plugin.version>3.8.0</maven-javadoc-plugin.version>
<maven-dependency-plugin.version>3.8.1</maven-dependency-plugin.version>
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
<maven-assembly-plugin.version>3.7.1</maven-assembly-plugin.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -1703,20 +1705,60 @@
<goal>jar</goal>
</goals>
<phase>package</phase>
<configuration>
<includeTransitiveDependencySources>true</includeTransitiveDependencySources>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>${maven-dependency-plugin.version}</version>
<executions>
<execution>
<id>unpack-resources</id>
<goals>
<goal>unpack-dependencies</goal>
</goals>
<phase>prepare-package</phase>
<configuration>
<classifier>sources</classifier>
<failOnMissingClassifierArtifact>false</failOnMissingClassifierArtifact>
<outputDirectory>${project.build.directory}/dependency-sources</outputDirectory>
<includeGroupIds>org.eclipse.*,org.glassfish.*,jakarta.*</includeGroupIds>
<includeArtifactIds>weld-*,hibernate-validator</includeArtifactIds>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${maven-source-plugin.version}</version>
<configuration>
<skipSource>true</skipSource>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>${maven-assembly-plugin.version}</version>
<executions>
<execution>
<id>attach-sources</id>
<id>create-sources</id>
<goals>
<goal>jar</goal>
<goal>single</goal>
</goals>
<phase>package</phase>
<configuration>
<attach>true</attach>
<finalName>${project.build.finalName}</finalName>
<descriptors>
<descriptor>${basedir}/src/assembly/sources.xml</descriptor>
</descriptors>
</configuration>
</execution>
</executions>
</plugin>
Expand All @@ -1729,6 +1771,7 @@
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
Expand Down
31 changes: 30 additions & 1 deletion appserver/extras/embedded/web/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
<properties>
<artifact-collection.directory>${project.build.directory}/jars</artifact-collection.directory>
<rar.directory>${project.build.directory}/rars</rar.directory>
<maven-javadoc-plugin.version>3.8.0</maven-javadoc-plugin.version>
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -1385,6 +1387,24 @@
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadoc</id>
<goals>
<goal>jar</goal>
</goals>
<phase>package</phase>
<configuration>
<includeTransitiveDependencySources>true</includeTransitiveDependencySources>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
Expand Down Expand Up @@ -1432,11 +1452,20 @@
<includeTypes>zip</includeTypes>
<includeArtifactIds>derby</includeArtifactIds>
<includes>**/lib/**,**/bin/**</includes>
<includeGroupIds>org.eclipse.*,org.glassfish.*,jakarta.*</includeGroupIds>
<includeArtifactIds>weld-*,hibernate-validator</includeArtifactIds>
</configuration>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${maven-source-plugin.version}</version>
<configuration>
<skipSource>true</skipSource>
</configuration>
</plugin>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
Expand Down
20 changes: 0 additions & 20 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,27 +45,12 @@

<properties>
<project.build.outputTimestamp>2025-04-22T16:51:45Z</project.build.outputTimestamp>
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
</properties>

<build>
<defaultGoal>install</defaultGoal>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${maven-source-plugin.version}</version>
<executions>
<execution>
<id>aggregate-sources</id>
<goals>
<goal>aggregate</goal>
</goals>
<phase>verify</phase>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<version>3.1.4</version>
Expand Down Expand Up @@ -128,11 +113,6 @@
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
</plugin>
</plugins>
</build>

Expand Down
Loading