Skip to content

Fixed NPEs in JDBC pooling + extended performance test #25756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixed NPEs in JDBC pooling + extended performance test #25756

wants to merge 5 commits into from

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Oct 28, 2025

Test

  • Can use embedded OR server as an alternative
  • Parameters were extracted to own class, makes experiments easy
  • create+list separated
  • Using ShrinkWrap instead of the dependency plugin to resolve dependencies makes possible also running the test in IDE.

ConnectionPool

  • extracted methods made code safer to NPEs
  • System.Logger
  • fixed several issues with wait-notify; could also time out

dmatej added 4 commits October 28, 2025 21:25
@dmatej
Extended benchmark test example
1485007 
- Is able to reproduce several types of errors

Signed-off-by: David Matějček <[email protected]>
@dmatej
ServerFiles were throwing NPE
7a9804d 
- There is a path where embedded uses this method too, then thrown NPE

Signed-off-by: David Matějček <[email protected]>
@dmatej
Option enum: conventions
fe57b6f 
Signed-off-by: David Matějček <[email protected]>
@dmatej
Connection pools - refactoring
9109809 
- code cleanup to reduce risk of NPEs reproducible by the performance test

Signed-off-by: David Matějček <[email protected]>
@dmatej
Copy link
Contributor Author

dmatej commented Oct 28, 2025

#25752 is related a bit - with that I could enable the monitoring for embedded too :-)

@dmatej dmatej marked this pull request as ready for review October 29, 2025 13:28
@dmatej dmatej added this to the 7.1.0 milestone Oct 29, 2025
@dmatej
Updated TestContainers
084d279 
- Attempt to fix incompatible JNA on Eclipse's Jenkins

Signed-off-by: David Matějček <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working build and test improvement code cleaning

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@dmatej