Improve int-parsing - fixes #1885#1886
Open
philipwhiuk wants to merge 1 commit intoeclipse-ee4j:masterfrom
Open
Improve int-parsing - fixes #1885#1886philipwhiuk wants to merge 1 commit intoeclipse-ee4j:masterfrom
philipwhiuk wants to merge 1 commit intoeclipse-ee4j:masterfrom
Conversation
Contributor
|
@philipwhiuk : you should first sign the eclipsefdn/eca in order for this to proceed. Please also consider my comment in #1885 Thanks |
Author
|
I was matching the behaviour in the handling of malformed URLs. I'll look again and see what the best option is for the flag and sign the ECA. |
Contributor
Yes I know but we need to know what it means since the error (which wont be fatal) is recoverable v. not recoverable errors |
philipwhiuk
force-pushed
the
improveIntParsing
branch
from
06371da to
730a365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.