Fix Grizzly on close when error #6017
Open
+20
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is related to #6012 but it does not fix it in Tomcat.
The issue I found is that when there is an error and
jersey.config.server.response.setStatusOverSendErroris nottrue, it writes in the response, and it later fails within the same request with:Internally in Grizzly response, the response was committed. This can be check inside:
org.glassfish.grizzly.http.server.Response#responseLater when it is getting closed,
CommittingOutputStreamdoes not know about this. ItsisCommittedisfalse, and it fails when it tries to commit again.It is likely we could have this issue in other web containers too.