Allow injecting HttpExchange #6029
Open
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthiasvanderhallen
force-pushed
the
HttpExchangeInjection
branch
2 times, most recently
from
6a09193 to
c1f6a5f
Compare
…ntainer-specific binder Signed-off-by: Matthias Van der Hallen <[email protected]>
Matthiasvanderhallen
force-pushed
the
HttpExchangeInjection
branch
from
c1f6a5f to
21e9c79
Compare
Signed-off-by: Matthias Van der Hallen <[email protected]>
Matthiasvanderhallen
force-pushed
the
HttpExchangeInjection
branch
from
46c8a74 to
24cf8e3
Compare
Signed-off-by: Matthias Van der Hallen <[email protected]>
Matthiasvanderhallen
force-pushed
the
HttpExchangeInjection
branch
from
24cf8e3 to
f26e683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
JdkHttpHandlerContainerto provide container-specific custom bindings; I wrote it to align withJettyHttpContainerand itsRequestandResponseinjectables.The value of being able to inject the
HttpExchangeis e.g. being able to get the remote socket address (HttpExchange::getRemoteAddress()) for auditing or getting the peer certificates (By getting the SSLSession from the HttpsExchange).It also improves feature parity between different containers.