Skip to content

Conversation

@eheeren
Copy link

@eheeren eheeren commented Feb 15, 2019

#34

Signed-off-by: Ed Heeren [email protected]

@eheeren
Copy link
Author

eheeren commented Feb 15, 2019

The associated issue is #34 .

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year is not updated (it’s 2019), introduced property is not documented and there is no test. Correct this , please

// Therefore, we are adding a new system property
// -Djaxb.allowNonNillableArray=true
// to implement the behavior requested by the customer.
static final boolean JAXB_ALLOWNONNILLABLEARRAY = getBooleanSystemProperty("jaxb.allowNonNillableArray").booleanValue();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property name should probably start with ‘com.sun.xml.ws...’. Also what is the impact of this change, if one uses MOXy instead of JAXB-RI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants