Skip to content

Use convenience factory methods for collections #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use convenience factory methods for collections #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impl/src/test/java/org/eclipse/parsson/tests/JsonBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static Map<String, Object> buildPersonAsMap() {
person.put("lastName", "Smith");
person.put("age", 25);

Map<String, Object> address = Optional.of(new HashMap<String, Object>()).get();
Map<String, Object> address = new HashMap<>();
address.put("streetAddress", "21 2nd Street");
address.put("city", "New York");
address.put("state", "NY");
Expand Down
8 changes: 2 additions & 6 deletions impl/src/test/java/org/eclipse/parsson/tests/JsonGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,7 @@ void testGeneratorBuf() {
@Test
void testBufferPoolFeature() {
final JsonParserTest.MyBufferPool bufferPool = new JsonParserTest.MyBufferPool(1024);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);

JsonGeneratorFactory factory = Json.createGeneratorFactory(config);
JsonGenerator generator = factory.createGenerator(new StringWriter());
Expand All @@ -518,9 +516,7 @@ void testBufferSizes() {
JsonBuilderFactory bf = Json.createBuilderFactory(null);
for(int size=10; size < 1000; size++) {
final JsonParserTest.MyBufferPool bufferPool = new JsonParserTest.MyBufferPool(size);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);
JsonGeneratorFactory gf = Json.createGeneratorFactory(config);

StringBuilder sb = new StringBuilder();
Expand Down
12 changes: 3 additions & 9 deletions impl/src/test/java/org/eclipse/parsson/tests/JsonParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,9 +693,7 @@ boolean isRecycleCalled() {
@Test
void testBufferPoolFeature() {
final MyBufferPool bufferPool = new MyBufferPool(1024);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);

JsonParserFactory factory = Json.createParserFactory(config);
try (JsonParser parser = factory.createParser(new StringReader("[]"))) {
Expand All @@ -711,9 +709,7 @@ void testBufferSizes() {
Random r = new Random(System.currentTimeMillis());
for(int size=100; size < 1000; size++) {
final MyBufferPool bufferPool = new MyBufferPool(size);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);
JsonParserFactory factory = Json.createParserFactory(config);

StringBuilder sb = new StringBuilder();
Expand Down Expand Up @@ -790,9 +786,7 @@ void testIntegerUsingStandardBuffer() throws Throwable {
void testStringUsingBuffers() throws Throwable {
for(int size=20; size < 500; size++) {
final MyBufferPool bufferPool = new MyBufferPool(size);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);
JsonParserFactory factory = Json.createParserFactory(config);

StringBuilder sb = new StringBuilder();
Expand Down
4 changes: 1 addition & 3 deletions impl/src/test/java/org/eclipse/parsson/tests/JsonReaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,7 @@ void testDuplicateKeysLast() {
void testEmptyStringUsingBuffers() throws Throwable {
for(int size=20; size < 500; size++) {
final JsonParserTest.MyBufferPool bufferPool = new JsonParserTest.MyBufferPool(size);
Map<String, Object> config = new HashMap<String, Object>() {{
put(BufferPool.class.getName(), bufferPool);
}};
Map<String, Object> config = Map.of(BufferPool.class.getName(), bufferPool);
JsonReaderFactory factory = Json.createReaderFactory(config);

StringBuilder sb = new StringBuilder();
Expand Down
Loading