Skip to content

JsonStructureParser fixes #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JsonStructureParser fixes #145

wants to merge 1 commit into from

Conversation

@marschall
Copy link
Contributor

@marschall marschall commented Dec 14, 2024

  • fix getObject() to work on root object
  • fix getObject() to advance parser state
  • fix getArray() to work on root array
  • fix getArray() to advance parser state

@marschall
Copy link
Contributor Author

marschall commented Dec 14, 2024 •
edited
Loading

Unfortunately 9d67960 introduced some bugs:

  • #getObject() does not work on the root object
  • #getObject() does not advance the parser state to END_OBJECT as required by the method contract
  • #getArray() does not work on the array object
  • #getArray() does not advance the parser state to END_ARRAY as required by the method contract
  • #getValue() does not work on the root object or array

@marschall
JsonStructureParser fixes
4729185 
- fix getObject() to work on root object
- fix getObject() to advance parser state
- fix getValue() to work on root object
- fix getArray() to work on root array
- fix getArray() to advance parser state
- fix getValue() to work on root array
@marschall marschall force-pushed the fix-getObject-getArray branch from c850737 to 4729185 Compare December 14, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marschall