Skip to content

introduce null-save JsonObjectBuilder.add and JsonGenerator.write met… #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

introduce null-save JsonObjectBuilder.add and JsonGenerator.write met… #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impl/src/main/java/org/eclipse/parsson/JsonArrayBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ public int hashCode() {
@Override
public String toString() {
StringWriter sw = new StringWriter();
try (JsonWriter jw = new JsonWriterImpl(sw, bufferPool)) {
try (JsonWriter jw = new JsonWriterImpl(sw, bufferPool, Collections.emptyMap())) {
jw.write(this);
}
return sw.toString();
Expand Down
16 changes: 8 additions & 8 deletions impl/src/main/java/org/eclipse/parsson/JsonBuilderFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
package org.eclipse.parsson;

import java.util.Collection;
import java.util.Map;

import org.eclipse.parsson.api.BufferPool;

import jakarta.json.JsonObject;
import jakarta.json.JsonArray;
import jakarta.json.JsonArrayBuilder;
import jakarta.json.JsonBuilderFactory;
import jakarta.json.JsonObject;
import jakarta.json.JsonObjectBuilder;
import java.util.Collections;
import java.util.Map;

/**
* @author Jitendra Kotamraju
Expand All @@ -35,25 +35,25 @@ class JsonBuilderFactoryImpl implements JsonBuilderFactory {
private final BufferPool bufferPool;
private final boolean rejectDuplicateKeys;

JsonBuilderFactoryImpl(BufferPool bufferPool, boolean rejectDuplicateKeys) {
this.config = Collections.emptyMap();
JsonBuilderFactoryImpl(BufferPool bufferPool, boolean rejectDuplicateKeys, Map<String, ?> config) {
this.config = config;
this.bufferPool = bufferPool;
this.rejectDuplicateKeys = rejectDuplicateKeys;
}

@Override
public JsonObjectBuilder createObjectBuilder() {
return new JsonObjectBuilderImpl(bufferPool, rejectDuplicateKeys);
return new JsonObjectBuilderImpl(bufferPool, rejectDuplicateKeys, config);
}

@Override
public JsonObjectBuilder createObjectBuilder(JsonObject object) {
return new JsonObjectBuilderImpl(object, bufferPool, rejectDuplicateKeys);
return new JsonObjectBuilderImpl(object, bufferPool, rejectDuplicateKeys, config);
}

@Override
public JsonObjectBuilder createObjectBuilder(Map<String, Object> object) {
return new JsonObjectBuilderImpl(object, bufferPool, rejectDuplicateKeys);
return new JsonObjectBuilderImpl(object, bufferPool, rejectDuplicateKeys, config);
}

@Override
Expand Down
12 changes: 6 additions & 6 deletions impl/src/main/java/org/eclipse/parsson/JsonGeneratorFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,22 @@ class JsonGeneratorFactoryImpl implements JsonGeneratorFactory {
@Override
public JsonGenerator createGenerator(Writer writer) {
return prettyPrinting
? new JsonPrettyGeneratorImpl(writer, bufferPool)
: new JsonGeneratorImpl(writer, bufferPool);
? new JsonPrettyGeneratorImpl(writer, bufferPool, config)
: new JsonGeneratorImpl(writer, bufferPool, config);
}

@Override
public JsonGenerator createGenerator(OutputStream out) {
return prettyPrinting
? new JsonPrettyGeneratorImpl(out, bufferPool)
: new JsonGeneratorImpl(out, bufferPool);
? new JsonPrettyGeneratorImpl(out, bufferPool, config)
: new JsonGeneratorImpl(out, bufferPool, config);
}

@Override
public JsonGenerator createGenerator(OutputStream out, Charset charset) {
return prettyPrinting
? new JsonPrettyGeneratorImpl(out, charset, bufferPool)
: new JsonGeneratorImpl(out, charset, bufferPool);
? new JsonPrettyGeneratorImpl(out, charset, bufferPool, config)
: new JsonGeneratorImpl(out, charset, bufferPool, config);
}

@Override
Expand Down
Loading