Fixed: Memory view not supporting 64-bit address while using GnuMcuLaunch #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
approved these changes
Jan 6, 2026
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
On code inspection this looks right to me.
Contributor
|
Is the GdbMemoryBlockRetrieval class available in the older Eclipse that these plugins are based on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #645
CDT have added support for 64-bit memory addresses long before. Code changes for the support are in the class GdbMemoryBlockRetrieval which inherits from DsfMemoryBlockRetrieval. Embedded CDT launches are using GnuMcuLaunch class (Embedded CDT launcher, used to initialize the memory block retrieval used by the Peripherals view). This launcher uses PeripheralMemoryBlockRetrieval which directly inherits from DsfMemoryBlockRetrieval and misses the 64-bit support in GdbMemoryBlockRetrieval class. If parent class of PeripheralMemoryBlockRetrieval is changed to GdbMemoryBlockRetrieval memory view correctly displays the address contents.