Merged
Conversation
agarciadom
changed the title
agarciadom
changed the title
Contributor
Author
|
I've gone ahead and tried implementing the change. Right-clicking on a problem with one or more fixes will show a "Quick Fix..." option. When selected, it'll precompute all the titles of the fixes (allowing for stopping at a breakpoint if desired), and then it will show a dialog. The chosen fix could also stop at a breakpoint if needed. This is now ready for a full review. |
… support title breakpoints
agarciadom
force-pushed
the
evl-fix-debug
branch
from
5b1017c to
7664bbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187.
Here is a WIP pull request for adding debugging support to EVL fixes.
This is trickier than it seems, as it breaks an assumption we had in our DAP support: that modules ran to completion and then finished. I had to move the concept of when a module was "done" to a new method in the IEolDebugger interface: the
done()method in IEolDebugger doesn't work as it is called after the execution listener'sfinishedExecutingmethod, which is where the debug adapter reacts to the program having completed its execution.I also had to tweak the EVL UI in Eclipse so that it won't block when we hit a breakpoint in the middle of applying a fix. We need to do something similar for computing the titles of the fixes, but this means we have to change from a context menu, to something like the "quick fixes" dialog in Eclipse.
@kolovos, would you be OK with the above change in the Validation view?