Skip to content

Conversation

@eclipse-equinox-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Test Results

  846 files  ±0    846 suites  ±0   1h 47m 17s ⏱️ -49s
2 234 tests ±0  2 181 ✅  -  4   49 💤 ±0  1 ❌ +1  3 🔥 +3 
6 702 runs  ±0  6 543 ✅  - 10  149 💤 ±0  1 ❌ +1  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit 1bd973b. ± Comparison against base commit d45517b.

♻️ This comment has been updated with latest results.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep this for now, this will likely change again when the missing deprecation cleanups have been run successfully...

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.osgi.tests branch 3 times, most recently from 9a4c072 to e3b93b1 Compare November 14, 2025 04:31
@akurtakov
Copy link
Member

@laeubi Is there a reason to still block this one?

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.osgi.tests branch from e3b93b1 to af23160 Compare December 1, 2025 04:49
@eclipse-equinox-bot
Copy link
Contributor Author

eclipse-equinox-bot commented Dec 1, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.osgi.tests/META-INF/MANIFEST.MF
bundles/org.eclipse.osgi.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 9a151b06399d9a03f7ab9e3ccfe76d91d96df691 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <[email protected]>
Date: Thu, 11 Dec 2025 04:50:07 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.osgi.tests/META-INF/MANIFEST.MF b/bundles/org.eclipse.osgi.tests/META-INF/MANIFEST.MF
index 03825f97f..d1ad9e69d 100644
--- a/bundles/org.eclipse.osgi.tests/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.osgi.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Core OSGi Tests
 Bundle-SymbolicName: org.eclipse.osgi.tests;singleton:=true
-Bundle-Version: 3.22.400.qualifier
+Bundle-Version: 3.22.500.qualifier
 Bundle-Vendor: Eclipse.org
 Require-Bundle: 
  org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
diff --git a/bundles/org.eclipse.osgi.tests/pom.xml b/bundles/org.eclipse.osgi.tests/pom.xml
index 4978b975e..58afd4ad8 100644
--- a/bundles/org.eclipse.osgi.tests/pom.xml
+++ b/bundles/org.eclipse.osgi.tests/pom.xml
@@ -19,7 +19,7 @@
   </parent>
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.osgi.tests</artifactId>
-  <version>3.22.400-SNAPSHOT</version>
+  <version>3.22.500-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.osgi.tests branch 7 times, most recently from 6b2d979 to 935c4cb Compare December 8, 2025 04:39
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.osgi.tests branch 5 times, most recently from 549c398 to cd00702 Compare December 13, 2025 04:21
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.osgi.tests branch from cd00702 to 1bd973b Compare December 16, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants