Enable Control Flow Guard in Windows executables

[laeubi]

Add /guard:cf flag to compilation and linking steps in make_win64.mak to enable Control Flow Guard protection. Stack protection with -GS flag was already enabled.

Fixes #851

@njakubiak can you check if this fixes the issue for you?

[github-actions]

Test Results

  282 files   -   564    282 suites   - 564   36m 33s ⏱️ - 1h 8m 23s
2 234 tests ±    0  2 184 ✅  -     1  50 💤 + 1  0 ❌ ±0 
2 234 runs   - 4 468  2 184 ✅  - 4 369  50 💤  - 99  0 ❌ ±0 

Results for commit bda8d95. ± Comparison against base commit 205d931.

This pull request skips 1 test.

AutomatedTests AllTests BasicLocationTests ‑ testUNC

♻️ This comment has been updated with latest results.

[njakubiak]

@njakubiak can you check if this fixes the issue for you?

I don't have the ability to build this project, but I can check the executable if one can be built and provided.

[HannesWell]

but I can check the executable if one can be built and provided.

The build archives the the built binaries, for example for build No.1 at
https://ci.eclipse.org/releng/job/equinox/job/PR-1205/1/artifact/equinox.binaries/

[njakubiak]

I downloaded the Windows x64 eclipse.exe executable provided at that link, and verified using Sysinternals Process Explorer that control flow guard is enabled.

[laeubi]

@tjwatson What do you think should we merge this for RC1 or better wait for the next release cycle?

[merks]

FYI, I tried copying the eclipse_*dll and the eclipse.exe into an installation and it did not appear to cause any immediate problems.

[laeubi]

Something is broken with the native builds, we need to wait for @HannesWell here if no one else has an idea what might gets wrong.

[HannesWell]

Something is broken with the native builds, we need to wait for @HannesWell here if no one else has an idea what might gets wrong.

At the moment one of the Windows build agents is offline. I asked the IT team to re-connect it:

• https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6984

The previous build failed after the native build succeeded. I haven't investigated yet if this is related.

[arunjose696]

At the moment one of the Windows build agents is offline. I asked the IT team to re-connect it:

• https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6984

From the issue, it looks like the agent is now back online. Could someone please rerun the workflows to verify?
It would also be great if you could rerun the workflows for the following PR, which is affected by the same issue:

• Remove autoscale upper limit to match SWT DPIUtil #1213

[laeubi]

@arunjose696 I already rerun the workflow, but now the x86 workflow fails (that previously succeeded).

So it seems for some reasons the both windows agents influence each other and only one of them can succeed at a time.

[HannesWell]

I already rerun the workflow, but now the x86 workflow fails (that previously succeeded).

After another rebuild the native build now succeeded. But the subsequent build failed due to missing version increments on the Windows fragments for the equinox launcher. But this can be explained, because the fragment content changes without a source-file within them being touched.
I added an the bump manually.

[laeubi]

The Jenkins build succeed, to make progress here I merge this anyways GH actions currently seem to be broken.