Deprecate (and mark for removal) ExtendedHttpService#438
Deprecate (and mark for removal) ExtendedHttpService#438laeubi wants to merge 1 commit intoeclipse-equinox:masterfrom
Conversation
|
+1 |
See |
I highlighted the important part ;-) |
That is not helpful. You asserted that |
|
The point is that we do not need a public API to implement HttpRegistryManager it could be a private one, so if no one except internal implementations is calling that API its not used, and if you look at the implementation it does not even use that API at all, it looks if the service and checks for a method that has a special signature, so as long as the EquinoxHttp service has a public method it will still work, it does not need it to be mentioned in a public API interface. |
laeubi
force-pushed
the
deprecate_ExtendedHttpService
branch
from
7844487 to
e91f28b
Compare
The ExtendedHttpService is effectively unused in platform and uses the abandoned HttpService it is API. We therefore should deprecate and remove that to get rid of the dependency here a more modern replacement for the purpose of this extended form (registering filters) is today the [Http Whiteboard Specification](https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.http.whiteboard.html)
laeubi
force-pushed
the
deprecate_ExtendedHttpService
branch
from
e91f28b to
0d082f6
Compare
|
I now started migration of the HelpCenter to using the Whiteboardservices, any help is welcome, it is always the same pattern and mostly one needs to find out where the servlet it used to test is is working properly: |
|
That's a bit special but also doable I'll look into this hopefully later on, for now it would be good to convert the easy ones first :-) |
4 participants
The ExtendedHttpService is effectively unused in platform and uses the abandoned HttpService it is API.
We therefore should deprecate and remove that to get rid of the dependency here a more modern replacement for the purpose of this extended form (registering filters) is today the Http Whiteboard Specification