Make var-args overload of NLS.bind() generic #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This should avoid the warnings fixed in: and I have also checked that the errors (which are actually just elevated compiler-warnings) from eclipse-platform/eclipse.platform#1854, would not have occurred with this. In general these changes should still be applied as they simplify code that is currently needlessly verbose, but I think it's better without warnings/errors to keep existing callers more comfortable. |
tjwatson
approved these changes
May 5, 2025
HannesWell
force-pushed
the
generic-NLS.bind
branch
from
8bbfb1f to
7377d0f
Compare
Member
Author
|
The failing quality-gate was indeed relevant as some calling projects that now get slight different byte-code generated because the var-args array generated by the compiler now can have a more specific type than |
This avoids a compiler warning if an explicit array of a sub-type of
Object[] is passed as last argument:
NLS.bind("message: {0} {1}", new String[] { "Hello", "World" })
The byte-code generated for the NLS.bind() method and for all its
callers is not changed by this adjustment. It just avoids what looks
like a source-compatibility issues with the previous introduction of
var-args in NLS.bind(). Although the example above works the same in all
three states.
Follow-up on:
- eclipse-equinox#936
Also touch calling projects that now get slight different byte-code
generated because the var-args array generated by the compiler now can
have a more specific type than Object[], common for all passed
arguments.
HannesWell
force-pushed
the
generic-NLS.bind
branch
from
7377d0f to
cf999b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a compiler warning if an explicit array of a sub-type of Object[] is passed as last argument:
NLS.bind("message: {0} {1}", new String[] { "Hello", "World" })The byte-code generated for the
NLS.bind()method and for all its callers is not changed by this adjustment. It just avoids what looks like a source-compatibility issues with the previous introduction of var-args inNLS.bind(). Although the example above works the same in all three states.Follow-up on: