Plugin section via file import does not work as expected#1004
Conversation
|
@merks could you please review this PR? |
Changes the behavior so that no plugins are selected by default when importing from a p2f file. This allows users to explicitly select only the plugins they want to install. Fix: eclipse-equinox#1003
subyssurendran666
force-pushed
the
plugin_section_via_file_import_not_as_expect_1003
branch
from
ddacb61 to
93bac43
Compare
|
@laeubi Could you please trigger the GitHub Copilot review for this PR? |
This is bad proposal & wrong solution. I want everything to be installed, I don't want to explicitly select anything, because the file in question has all what I need, and I do this literally every day. |
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
As explained, it is not a solution for the problem.
One situation I faced while setting up JDT.UI was that I only needed AssertJ and Mockito. However, the p2f file contains many other plugins as well. In that case, I had to manually deselect the unwanted plugins, or click “Deselect All” and then select only the required plugins. Because of this, the auto-selection process irritated me multiple times while setting up JDT.UI. The actual problem was slightly different. In the existing implementation, all plugins are selected by default. If the user clicks “Deselect All” and then tries to select the required plugin, all the plugins get auto-selected again, and the plugin that the user manually selected becomes deselected. To avoid this issue, I set all plugins to be deselected by default, and the problem was resolved. These are the reasons why I implemented it this way. I am open to implementing this in a different way, but auto-selecting all plugins by default can definitely cause inconvenience for users who do not need all the plugins. |
This is the bug. |
2 participants
Changes the behavior so that no plugins are selected by default when importing from a p2f file. This allows users to explicitly select only the plugins they want to install.
Fix: #1003