Add SVGs to org.eclipse.equinox.p2.ui bundles #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HannesWell It would be very kind of you if you can have a look at this PR and PR. These are the last two PRs for integrating SVGs (apart from the mylyn bundles that still have problems). It would be great if we could have them in the new Eclipse release. |
This commit adds SVGs for all icons in the bundles `org.eclipse.equinox.p2.ui`, `org.eclipse.equinox.p2.ui.admin`, `org.eclipse.equinox.p2.ui.admin.rcp`, `org.eclipse.equinox.p2.ui.discovery`, `org.eclipse.equinox.p2.ui.importexport`, `org.eclipse.equinox.p2.ui.sdk` and `org.eclipse.equinox.p2.ui.sdk.scheduler` except for the following as it is not available as SVG yet: org.eclipse.equinox.p2.ui.importexport/icons/obj16/install-handler.svg
|
Let's just move forward and fix any problems that might show up. 😀 |
Thank you @merks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SVGs for all icons in the bundles
org.eclipse.equinox.p2.ui,org.eclipse.equinox.p2.ui.admin,org.eclipse.equinox.p2.ui.admin.rcp,org.eclipse.equinox.p2.ui.discovery,org.eclipse.equinox.p2.ui.importexport,org.eclipse.equinox.p2.ui.sdkandorg.eclipse.equinox.p2.ui.sdk.schedulerexcept for the following as it is not available as SVG yet:org.eclipse.equinox.p2.ui.importexport/icons/obj16/install-handler.svg
I deleted the constants
T_TOOL,FIND_CLEARandFIND_CLEAR_DISABLEDin classorg.eclipse.equinox.internal.p2.ui.discovery.DiscoveryImagesas the specified GIFs do not exist and the constants are not used. The bundle is exported asx-internal=true.I changed one icon path
icons/install_wiz.pngin the classorg.eclipse.equinox.internal.p2.ui.sdk.scheduler.migration.MigrationWizardtoicons/wizban/install_wiz.svgas the former path did not lead to any icon in the specified bundleorg.eclipse.equinox.p2.ui.See also this PR for more information.