Skip to content

Conversation

merks
Copy link
Contributor

@merks merks commented May 12, 2025

  • Tests are failing depending on what is on the system PATH environment variable, i.e., the script find the wrong find executable, the one from git bash rather than the windows native find.
  • Do the same for reg.

- Tests are failing depending on what is on the system PATH environment
variable, i.e., the script find the wrong find executable, the one from
git bash rather than the windows native find.
- Do the same for `reg`.
Copy link

Test Results

  365 files  ±0    365 suites  ±0   42m 4s ⏱️ + 1m 30s
1 905 tests ±0  1 884 ✅ +3  3 💤 ±0  18 ❌  - 3 
6 587 runs  ±0  6 563 ✅ +3  6 💤 ±0  18 ❌  - 3 

For more details on these failures, see this check.

Results for commit 178bfea. ± Comparison against base commit 9ab47de.

@merks
Copy link
Contributor Author

merks commented May 12, 2025

The three failing tests for the windows native registry stopped failing.

@merks merks merged commit 086dd96 into eclipse-equinox:master May 12, 2025
10 of 12 checks passed
@merks merks deleted the pr-fix-bat branch May 12, 2025 16:55
@HannesWell
Copy link
Member

Should we try to revert this to see if this is also fixed by eclipse-platform/eclipse.platform.releng.aggregator#3042?

@merks
Copy link
Contributor Author

merks commented May 12, 2025

It’s a real problem that the script assumes the right things are on the path first. Launch eclipse from gitbash and this touch point will fail. How many other places make bad assumptions I don’t know but best to fix the assumption than make the environment conform to the assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants