Enforce SAMM prefix & cleanup ModelGroupingUtils#101
Merged
michelu89 merged 1 commit intoeclipse-esmf:mainfrom Mar 9, 2026
Merged
Conversation
Replace vavr Try usage with explicit null-checking for SAMM prefix and throw a clear IllegalStateException when an outdated BAMM definition is detected. Also tidy imports and reformat stream/Optional usage, simplify lambdas and grouping/collection calls, and perform minor refactors for readability. Functional behavior is preserved except that missing SAMM prefixes now produce a descriptive error pointing out legacy BAMM usage.
Contributor
Author
sha4be
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace vavr Try usage with explicit null-checking for SAMM prefix and throw a clear IllegalStateException when an outdated BAMM definition is detected. Also tidy imports and reformat stream/Optional usage, simplify lambdas and grouping/collection calls, and perform minor refactors for readability. Functional behavior is preserved except that missing SAMM prefixes now produce a descriptive error pointing out legacy BAMM usage.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes #(number of issue in GitHub)
Type of change
Please delete options that are not relevant.
Checklist:
Additional notes:
Add any other notes or comments here.