Skip to content

Enforce SAMM prefix & cleanup ModelGroupingUtils#101

Merged
michelu89 merged 1 commit intoeclipse-esmf:mainfrom
bci-oss:fix/include-message-for-old-model-versions
Mar 9, 2026
Merged

Enforce SAMM prefix & cleanup ModelGroupingUtils#101
michelu89 merged 1 commit intoeclipse-esmf:mainfrom
bci-oss:fix/include-message-for-old-model-versions

Conversation

@michelu89
Copy link
Contributor

@michelu89 michelu89 commented Mar 9, 2026

Replace vavr Try usage with explicit null-checking for SAMM prefix and throw a clear IllegalStateException when an outdated BAMM definition is detected. Also tidy imports and reformat stream/Optional usage, simplify lambdas and grouping/collection calls, and perform minor refactors for readability. Functional behavior is preserved except that missing SAMM prefixes now produce a descriptive error pointing out legacy BAMM usage.

Description

Please include a summary of the changes and the related issue. List any dependencies that are required for this change.

Fixes #(number of issue in GitHub)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

Add any other notes or comments here.

Replace vavr Try usage with explicit null-checking for SAMM prefix and throw a clear IllegalStateException when an outdated BAMM definition is detected. Also tidy imports and reformat stream/Optional usage, simplify lambdas and grouping/collection calls, and perform minor refactors for readability. Functional behavior is preserved except that missing SAMM prefixes now produce a descriptive error pointing out legacy BAMM usage.
@michelu89 michelu89 self-assigned this Mar 9, 2026
@michelu89
Copy link
Contributor Author

@michelu89 michelu89 merged commit 22f7236 into eclipse-esmf:main Mar 9, 2026
7 checks passed
@michelu89 michelu89 deleted the fix/include-message-for-old-model-versions branch March 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants