Skip to content

Commit 94491f0

Browse files
committed
Some code restructuring for better readability
Signed-off-by: Johannes Kristan <[email protected]>
1 parent 7354343 commit 94491f0

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

core/sds-aspect-model-aas-generator/src/main/java/io/openmanufacturing/sds/aspectmodel/aas/AspectModelAASVisitor.java

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -172,23 +172,19 @@ private interface SubmodelElementBuilder {
172172

173173
@Override
174174
public Environment visitBase( final ModelElement base, final Context context ) {
175-
176175
return context.getEnvironment();
177176
}
178177

179178
@Override
180179
public Environment visitAspect( final Aspect aspect, Context context ) {
181-
182180
if ( context == null ) {
183181
final Submodel submodel = new DefaultSubmodel.Builder().build();
184182
Environment environment = new DefaultEnvironment.Builder().submodels( Collections.singletonList( submodel ) ).build();
185-
186183
context = new Context(environment, submodel );
187184
context.setEnvironment(environment);
188185
}
189186

190187
final Submodel submodel = context.getSubmodel();
191-
192188
submodel.setIdShort( aspect.getName() );
193189
submodel.setSemanticId( buildReferenceToConceptDescription( aspect ) );
194190
submodel.setDescription( map( aspect.getDescriptions() ) );
@@ -338,6 +334,10 @@ private LangString map( final Locale locale, final String value ) {
338334
return createLangString( value, locale.getLanguage() );
339335
}
340336

337+
private LangString createLangString(String text, String locale){
338+
return new DefaultLangString.Builder().language( locale ).text( text ).build();
339+
}
340+
341341
private Reference buildReferenceToEnumValue( final Enumeration enumeration, final Object value ) {
342342
final Key key =
343343
new DefaultKey.Builder()
@@ -433,9 +433,6 @@ private DataSpecificationIEC61360 extractDataSpecificationContent( final Propert
433433
.build();
434434
}
435435

436-
private LangString createLangString(String text, String locale){
437-
return new DefaultLangString.Builder().language( locale ).text( text ).build();
438-
}
439436

440437
private DataSpecificationIEC61360 extractDataSpecificationContent( final Aspect aspect ) {
441438
final List<LangString> definitions = map( aspect.getDescriptions() );
@@ -447,13 +444,6 @@ private DataSpecificationIEC61360 extractDataSpecificationContent( final Aspect
447444
.build();
448445
}
449446

450-
private void createSubmodelElement( final SubmodelElementBuilder op, final Context context ) {
451-
final Property property = context.getProperty();
452-
final SubmodelElement submodelElement = op.build( property );
453-
context.setPropertyResult( submodelElement );
454-
createConceptDescription( property, context );
455-
}
456-
457447
private DataTypeIEC61360 mapIEC61360DataType( final Optional<Characteristic> characteristic ) {
458448
return mapIEC61360DataType( characteristic.flatMap( Characteristic::getDataType ).map( Type::getUrn ).orElse( RDF.langString.getURI() ) );
459449
}
@@ -472,6 +462,13 @@ private DataTypeDefXsd mapAASXSDataType( final String urn ) {
472462
return AAS_XSD_TYPE_MAP.getOrDefault( resource, DataTypeDefXsd.STRING );
473463
}
474464

465+
private void createSubmodelElement( final SubmodelElementBuilder op, final Context context ) {
466+
final Property property = context.getProperty();
467+
final SubmodelElement submodelElement = op.build( property );
468+
context.setPropertyResult( submodelElement );
469+
createConceptDescription( property, context );
470+
}
471+
475472
@Override
476473
public Environment visitCharacteristic(
477474
final Characteristic characteristic, final Context context ) {

0 commit comments

Comments
 (0)