Skip to content

Conversation

@shijinrajbosch
Copy link

Description

Added documentation for mapping Aspect Models to Apache Parquet format

Fixes #(number of issue in GitHub)

Type of change

  • Added documentation for mapping Aspect Models to Apache Parquet format

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works


* **String Max Size**: We need the max size of String properties in order to represent as Apache Parquet FIXED_LEN_BYTE_ARRAY .
But we could not find the correct functionality for all the types in the ESMF project to determine the maximum size of a String property.
It might indicate a ESMF bug, which causes an issue where loading a certain model with a Property + Trait + LengthConstraint does not return the Constraints defined for the given Trait.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that not as a bug it is just not defined. Also considering it could be a long text meaning it depends and requires a trait to define the range, see also the XSD definition.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @waltersve ,

Many thanks for the review comments.

We will analyze the Aspect models that include properties with length constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants