Fix PrecisionRectangle#getLeft #getRight inconsistency #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x/y value of PrecisionRectangle#getLeft and PrecisionRectangle#getRight can return a different x or y value in comparision to the behavior of the other directional methods in PrecisionRectangle as #getBottomLeft. This commit overrides #getLeft and #getRight in PrecisionRectangle.
Contributor
|
How critical is this change? There is little chance to respond to any side-effects that might be introduced by this change, given how close we are to the RC2. |
Contributor
Author
|
We currently don't have any issues with that, but you could get into a similar situation we had with PrecisionRectangle#getBottom. Still, I would not consider this critical. |
Contributor
|
Hm... This edge-case has already existed in the previous release so it wouldn't be a regression. It also shouldn't be relevant to the scaling, when translating the bounds of a figure through the scalable layers. So in that regard, I would prefer to merge this for the M1 and not the RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #870, the x/y value of PrecisionRectangle#getLeft and PrecisionRectangle#getRight can return a different x or y value in comparision to the behavior of the other directional methods in PrecisionRectangle as #getBottomLeft. This PR overrides #getLeft and #getRight in PrecisionRectangle.