Skip to content

Conversation

@haydar-metin
Copy link
Contributor

@haydar-metin haydar-metin commented Feb 19, 2025

What it does

Works on eclipse-glsp/glsp#1241

  • TODO: REMOVE MOVEMENT RESTRICTION BEFORE MERGE
    • It will fix the failing test

How to test

  • Trigger validation
  • Move a node to be above another node

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr
Copy link
Contributor

Changes look good to me and for the client/standalone example everything seems to work.
However, I quickly tested the change with the theia-integration an there the movement restriction feedback for routing handles is no longer properly applied:

image
With removing the !important it seems that another rule replaces the fill of the routing handles.
We should probably merge this and then retest the different integrations separately.

@haydar-metin
Copy link
Contributor Author

@tortmayr thanks! I will now fix those integrations.

@tortmayr tortmayr merged commit 93513ce into eclipse-glsp:master Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants