Skip to content

Adapt BringToFront to only support order-agnostic layouts#436

Merged
martin-fleck-at merged 1 commit intomasterfrom
issues/1554
Aug 28, 2025
Merged

Adapt BringToFront to only support order-agnostic layouts#436
martin-fleck-at merged 1 commit intomasterfrom
issues/1554

Conversation

@martin-fleck-at
Copy link
Copy Markdown
Contributor

What it does

  • Add additional property to layouts to indicate child order importance

Fixes eclipse-glsp/glsp#1554

How to test

  • Debug into the BringToFront command and evaluate: vbox and hbox should not bring to front, others should

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)
  • zorder module now requires bounds module as we need the layout registry

@martin-fleck-at martin-fleck-at force-pushed the issues/1554 branch 2 times, most recently from ffba9ce to bd2efc1 Compare August 26, 2025 14:20
Copy link
Copy Markdown
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@martin-fleck-at martin-fleck-at merged commit 76bfe43 into master Aug 28, 2025
7 checks passed
@martin-fleck-at martin-fleck-at deleted the issues/1554 branch August 28, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove moving selectable sub items to the bottom of a compartment when it is resizable

2 participants