Conversation
martin-fleck-at
requested changes
Aug 27, 2025
Contributor
Author
|
@martin-fleck-at After our offline discussion, I have now pushed a new Proposal and updated the PR description |
martin-fleck-at
requested changes
Aug 28, 2025
Contributor
martin-fleck-at
left a comment
There was a problem hiding this comment.
Overall very good change, I just have a few comments and questions :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Refactor our approach to handle model changes and introduce dedicated
IModelChangeService.ICommandStackinterface by adding an event to react to successfull command executionIModelChangeServiceto encapsulate model change handling from theEditorContextServicesimilar to how we do it for the selection change and theSelectionServiceIn addition:
Fixes eclipse-glsp/glsp/issues/1531
How to test
For testing a logger can be configured as event listener e.g:
Follow-ups
Changelog
Potentially breaking changes for Adopters that extend internal API:
_modelRootandonModelRootChangedEmitterproperties. Corresponding getters now forward to the ModelChangeServicenotifyModelRootChangedmethod (Probably no side effect for adopters. Method was only callable from commandstack anyways)