Update 2.3.0 #213
Merged
Update 2.3.0 #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
approved these changes
Jan 16, 2025
Contributor
martin-fleck-at
left a comment
martin-fleck-at
left a comment
There was a problem hiding this comment.
Changes look good to me but I haven't had the time yet to try all the examples manually. Will do yo soon!
| export class WorkflowEdgeCreationChecker implements EdgeCreationChecker { | ||
| isValidSource(edgeType: string, sourceElement: GModelElement): boolean { | ||
| return edgeType !== ModelTypes.WEIGHTED_EDGE && sourceElement.type === ModelTypes.DECISION_NODE; | ||
| return edgeType === ModelTypes.WEIGHTED_EDGE && sourceElement.type === ModelTypes.DECISION_NODE; |
Contributor
There was a problem hiding this comment.
Good catch aligning that with the Java server!
Contributor
|
@tortmayr Managed to test all the examples now. Found some minor issues, please have a look at the latest commit and if you agree, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.