Skip to content

GLSP-1586: Adjust to new MenuItem API #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tortmayr merged 2 commits into from
Oct 20, 2025
Merged

GLSP-1586: Adjust to new MenuItem API #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9732969
GLSP-1586: Adjust to new MenuItem API
tortmayr Oct 7, 2025
a84c6ad
Address review feedback
tortmayr Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ...kflow/src/org/eclipse/glsp/example/workflow/provider/WorkflowContextMenuItemProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@
import static org.eclipse.glsp.example.workflow.utils.ModelTypes.AUTOMATED_TASK;
import static org.eclipse.glsp.example.workflow.utils.ModelTypes.MANUAL_TASK;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;

import org.eclipse.glsp.example.workflow.handler.GridSnapper;
import org.eclipse.glsp.graph.GPoint;
import org.eclipse.glsp.server.actions.SetEditModeAction;
import org.eclipse.glsp.server.features.contextmenu.ContextMenuItemProvider;
import org.eclipse.glsp.server.features.contextmenu.MenuItem;
import org.eclipse.glsp.server.model.GModelState;
Expand All @@ -41,16 +40,24 @@ public class WorkflowContextMenuItemProvider implements ContextMenuItemProvider
@Override
public List<MenuItem> getItems(final List<String> selectedElementIds, final GPoint position,
final Map<String, String> args) {
SetEditModeAction editModeAction = new SetEditModeAction(
modelState.isReadonly() ? SetEditModeAction.EDIT_MODE_EDITABLE : SetEditModeAction.EDIT_MODE_READONLY);
MenuItem editModeMenu = new MenuItem("editMode", "Readonly Mode", Arrays.asList(editModeAction), true);
editModeMenu.setToggled(modelState.isReadonly());

if (modelState.isReadonly()) {
return Collections.emptyList();
return Arrays.asList(editModeMenu);
}

GPoint snappedPosition = GridSnapper.snap(position);
MenuItem newAutTask = new MenuItem("newAutoTask", "Automated Task",
Arrays.asList(new CreateNodeOperation(AUTOMATED_TASK, snappedPosition)), true);
MenuItem newManTask = new MenuItem("newManualTask", "Manual Task",
Arrays.asList(new CreateNodeOperation(MANUAL_TASK, snappedPosition)), true);
MenuItem newChildMenu = new MenuItem("new", "New", Arrays.asList(newAutTask, newManTask), "add", "0_new");
return new ArrayList<>(List.of(newChildMenu));
MenuItem hiddenItem = new MenuItem("hiddenItem", "Should be hidden", Arrays.asList(), false);
MenuItem newChildMenu = new MenuItem("new", "New", Arrays.asList(newAutTask, newManTask, hiddenItem), "add",
"0_new");
return Arrays.asList(newChildMenu, editModeMenu);
}

}
14 changes: 11 additions & 3 deletions ...ns/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/contextmenu/MenuItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public class MenuItem extends LabeledAction {
private final List<MenuItem> children;
private boolean isEnabled;
private boolean isToggled;
private boolean isVisible;

public MenuItem(final String id, final String label, final List<Action> actions, final boolean isEnabled) {
this(id, label, actions, isEnabled, null);
Expand All @@ -41,7 +42,7 @@ public MenuItem(final String id, final String label, final List<Action> actions,

public MenuItem(final String id, final String label, final List<Action> actions, final boolean isEnabled,
final String icon, final String sortString) {
this(id, label, actions, icon, sortString, null, null, isEnabled, false, Collections.emptyList());
this(id, label, actions, icon, sortString, null, null, isEnabled, isEnabled, false, Collections.emptyList());
}

public MenuItem(final String id, final String label, final List<MenuItem> children) {
Expand All @@ -54,20 +55,22 @@ public MenuItem(final String id, final String label, final List<MenuItem> childr

public MenuItem(final String id, final String label, final List<MenuItem> children, final String group,
final String sortString) {
this(id, label, Collections.emptyList(), null, sortString, group, null, true, false, children);
this(id, label, Collections.emptyList(), null, sortString, group, null, true, true, false, children);
}

@SuppressWarnings("checkstyle:ParameterNumber")
public MenuItem(final String id, final String label, final List<Action> actions, final String icon,
final String sortString, final String group,
final String parentId, final boolean isEnabled, final boolean isToggled, final List<MenuItem> children) {
final String parentId, final boolean isEnabled, final boolean isVisible, final boolean isToggled,
final List<MenuItem> children) {
super(label, actions, icon);
this.id = id;
this.sortString = sortString;
this.children = children;
this.group = group;
this.parentId = parentId;
this.isEnabled = isEnabled;
this.isVisible = isVisible;
this.isToggled = isToggled;
}

Expand All @@ -92,4 +95,9 @@ public MenuItem(final String id, final String label, final List<Action> actions,
public String getSortString() { return sortString; }

public List<MenuItem> getChildren() { return children; }

public boolean isVisible() { return isVisible; }

public void setVisible(final boolean isVisible) { this.isVisible = isVisible; }

}