Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 16, 2024

Notes for Reviewer

This PR makes the max number of Client and Server configurable. This is important for small memory configurations.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the bugfix Solves a bug label Dec 16, 2024
@elBoberido elBoberido requested a review from elfenpiff December 16, 2024 16:15
@elBoberido elBoberido self-assigned this Dec 16, 2024
elfenpiff
elfenpiff previously approved these changes Dec 16, 2024
@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (f7f07b2) to head (9c09be4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   78.69%   78.68%   -0.02%     
==========================================
  Files         440      440              
  Lines       16981    16981              
  Branches     2361     2361              
==========================================
- Hits        13364    13362       -2     
- Misses       2736     2737       +1     
- Partials      881      882       +1     
Flag Coverage Δ
unittests 78.48% <ø> (-0.02%) ⬇️
unittests_timing 15.35% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...x_posh/include/iceoryx_posh/iceoryx_posh_types.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

elfenpiff
elfenpiff previously approved these changes Dec 16, 2024
@elBoberido elBoberido force-pushed the iox-2394-make-max-client-and-server-independently-configurable branch from f625b12 to 0dcaa10 Compare December 16, 2024 17:22
@elBoberido
Copy link
Member Author

@gpalmer-latai I think this is also interesting for you to reduce the size of the management segment

@elBoberido elBoberido merged commit e088257 into eclipse-iceoryx:main Dec 16, 2024
19 checks passed
@elBoberido elBoberido deleted the iox-2394-make-max-client-and-server-independently-configurable branch December 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Solves a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Max Client and Server cannot be configured independently of Max Publisher and Subscriber

2 participants