Skip to content

iox-#2011 Fix CI on release 2.0 branch#2423

Merged
elBoberido merged 2 commits intoeclipse-iceoryx:release_2.0from
elBoberido:iox-2011-fix-ci-on-release-2.0
Feb 24, 2025
Merged

iox-#2011 Fix CI on release 2.0 branch#2423
elBoberido merged 2 commits intoeclipse-iceoryx:release_2.0from
elBoberido:iox-2011-fix-ci-on-release-2.0

Conversation

@elBoberido
Copy link
Copy Markdown
Member

@elBoberido elBoberido commented Feb 24, 2025

Notes for Reviewer

This PR fixes the macOS build on the release branch and updates all ubuntu version used on the CI. Ubuntu 20.04 is currently faded out and will not be supported anymore from April first 2024.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2011-fix-ci-on-release-2.0 branch from dbb4f3d to 2e768c3 Compare February 24, 2025 07:21
@elBoberido elBoberido self-assigned this Feb 24, 2025
@elBoberido elBoberido requested a review from elfenpiff February 24, 2025 07:26
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (a4a1157) to head (2e768c3).
Report is 4 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2423      +/-   ##
===============================================
+ Coverage        78.47%   78.87%   +0.40%     
===============================================
  Files              370      369       -1     
  Lines            14219    15200     +981     
  Branches          2060     2105      +45     
===============================================
+ Hits             11158    11989     +831     
- Misses            2377     2495     +118     
- Partials           684      716      +32     
Flag Coverage Δ
unittests 78.08% <ø> (+0.37%) ⬆️
unittests_timing 15.65% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 208 files with indirect coverage changes

@elBoberido elBoberido merged commit 301d996 into eclipse-iceoryx:release_2.0 Feb 24, 2025
14 checks passed
@elBoberido elBoberido deleted the iox-2011-fix-ci-on-release-2.0 branch February 24, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants