Skip to content

iox-#2435: Rename Bzlmod module to iceoryx#2437

Merged
elBoberido merged 1 commit intoeclipse-iceoryx:mainfrom
lalten:iox-#2435_bzlmod-name
Mar 14, 2025
Merged

iox-#2435: Rename Bzlmod module to iceoryx#2437
elBoberido merged 1 commit intoeclipse-iceoryx:mainfrom
lalten:iox-#2435_bzlmod-name

Conversation

@lalten
Copy link
Contributor

@lalten lalten commented Mar 14, 2025

Notes for Reviewer

Rename Bzlmod module to iceoryx as per #2435 to follow conventions and make it easier to consume the repo as Bzlmod library.

Holding off with the changelog commit to avoid merge conflicts.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.25%. Comparing base (7592b2a) to head (9ee4a50).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files         445      445           
  Lines       17091    17091           
  Branches     2373     2373           
=======================================
+ Hits        13374    13375    +1     
  Misses       2835     2835           
+ Partials      882      881    -1     
Flag Coverage Δ
unittests 78.05% <ø> (+<0.01%) ⬆️
unittests_timing 15.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need to add this to the changelog since the bzlmod support was only added for the upcoming v3.0 release

@elBoberido elBoberido self-assigned this Mar 14, 2025
@elBoberido elBoberido added the technical debt unclean code and design flaws label Mar 14, 2025
@elBoberido elBoberido merged commit d307b83 into eclipse-iceoryx:main Mar 14, 2025
23 checks passed
@lalten lalten deleted the iox-#2435_bzlmod-name branch March 14, 2025 14:05
bazel-io pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Mar 14, 2025
Add https://github.com/eclipse-iceoryx/iceoryx/releases/tag/v2.95.4

Includes patches for these PRs:
* eclipse-iceoryx/iceoryx#2371
* eclipse-iceoryx/iceoryx#2433
* eclipse-iceoryx/iceoryx#2436
* eclipse-iceoryx/iceoryx#2437
* eclipse-iceoryx/iceoryx#2439

Added `test_targets` in presubmit as well, except for those that are
failing due to lack of resources in ci
feuerste pushed a commit to feuerste/bazel-central-registry that referenced this pull request Mar 18, 2025
Add https://github.com/eclipse-iceoryx/iceoryx/releases/tag/v2.95.4

Includes patches for these PRs:
* eclipse-iceoryx/iceoryx#2371
* eclipse-iceoryx/iceoryx#2433
* eclipse-iceoryx/iceoryx#2436
* eclipse-iceoryx/iceoryx#2437
* eclipse-iceoryx/iceoryx#2439

Added `test_targets` in presubmit as well, except for those that are
failing due to lack of resources in ci
filmil pushed a commit to filmil/bazel-central-registry that referenced this pull request Jun 23, 2025
Add https://github.com/eclipse-iceoryx/iceoryx/releases/tag/v2.95.4

Includes patches for these PRs:
* eclipse-iceoryx/iceoryx#2371
* eclipse-iceoryx/iceoryx#2433
* eclipse-iceoryx/iceoryx#2436
* eclipse-iceoryx/iceoryx#2437
* eclipse-iceoryx/iceoryx#2439

Added `test_targets` in presubmit as well, except for those that are
failing due to lack of resources in ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt unclean code and design flaws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Bzlmod module name should be iceoryx, not org_eclipse_iceoryx

2 participants