Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 31, 2025

Notes for Reviewer

Bump the version to v2.95.6 to make the gcc 8 bugfix and logging to stderr available to iceoryx2 via a tag.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. [~] Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff July 31, 2025 23:46
@elBoberido elBoberido self-assigned this Jul 31, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.24%. Comparing base (7374332) to head (1d8b0f9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   78.26%   78.24%   -0.02%     
==========================================
  Files         446      446              
  Lines       17107    17107              
  Branches     2373     2373              
==========================================
- Hits        13388    13386       -2     
  Misses       2839     2839              
- Partials      880      882       +2     
Flag Coverage Δ
unittests 78.04% <ø> (-0.02%) ⬇️
unittests_timing 15.30% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido merged commit a22f16a into eclipse-iceoryx:main Aug 1, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants