Skip to content

Conversation

@ipython3
Copy link
Contributor

@ipython3 ipython3 commented Aug 13, 2025

Use set(... CACHE BOOL "" FORCE) to ensure the cache is updated so these options are truly enabled

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido
Copy link
Member

@ipython3 can you also please change Closes TBD to Closes #2485 at the end of the PR description and also add #2485 to https://github.com/eclipse-iceoryx/iceoryx/blob/main/doc/website/release-notes/iceoryx-unreleased.md.

Use `set(... CACHE BOOL "" FORCE)` to ensure the cache is updated so these options are truly enabled
@ipython3 ipython3 force-pushed the iox-2485-force-update-dependent-options branch from 216edaf to da96c6d Compare August 13, 2025 15:54
@ipython3
Copy link
Contributor Author

Hi @elBoberido, Thank you for your patient guidance. I have completed both of these changes.

@elBoberido elBoberido self-requested a review August 13, 2025 15:59
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Once the CI is green, the PR can be merged

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (a22f16a) to head (da96c6d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
+ Coverage   78.24%   78.25%   +0.01%     
==========================================
  Files         446      446              
  Lines       17107    17107              
  Branches     2373     2373              
==========================================
+ Hits        13385    13387       +2     
  Misses       2839     2839              
+ Partials      883      881       -2     
Flag Coverage Δ
unittests 78.05% <ø> (+0.01%) ⬆️
unittests_timing 15.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido
Copy link
Member

@ipython3 it seems there is a hiccup with bazel downloading ncurses. The last time it fixed itself after some time. I'll trigger the build later today.

@elBoberido elBoberido merged commit bdfd805 into eclipse-iceoryx:main Aug 13, 2025
72 of 75 checks passed
@elBoberido
Copy link
Member

elBoberido commented Aug 13, 2025

@ipython3 thanks for your contribution :)

btw, it you are looking to use iceoryx with Python, iceoryx2 will have Python bindings with the next release. It is already merged to main -> https://github.com/eclipse-iceoryx/iceoryx2/tree/main/iceoryx2-ffi/python

@ipython3 ipython3 changed the title iox-eclipse-iceoryx#2485 Force update dependent options iox-#2485 Force update dependent options Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build options not set correctly

2 participants