-
Notifications
You must be signed in to change notification settings - Fork 450
iox-#2485 Force update dependent options #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2485 Force update dependent options #2487
Conversation
|
@ipython3 can you also please change |
Use `set(... CACHE BOOL "" FORCE)` to ensure the cache is updated so these options are truly enabled
216edaf to
da96c6d
Compare
|
Hi @elBoberido, Thank you for your patient guidance. I have completed both of these changes. |
elBoberido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Once the CI is green, the PR can be merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 78.24% 78.25% +0.01%
==========================================
Files 446 446
Lines 17107 17107
Branches 2373 2373
==========================================
+ Hits 13385 13387 +2
Misses 2839 2839
+ Partials 883 881 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@ipython3 it seems there is a hiccup with bazel downloading ncurses. The last time it fixed itself after some time. I'll trigger the build later today. |
|
@ipython3 thanks for your contribution :) btw, it you are looking to use iceoryx with Python, iceoryx2 will have Python bindings with the next release. It is already merged to main -> https://github.com/eclipse-iceoryx/iceoryx2/tree/main/iceoryx2-ffi/python |
Use
set(... CACHE BOOL "" FORCE)to ensure the cache is updated so these options are truly enabledNotes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References