Skip to content

Conversation

@FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented Oct 23, 2025

Notes for Reviewer

See title.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
    [ ] Changelog updated in the unreleased section including API breaking changes
  3. Branch follows the naming format (iox-123-this-is-a-branch)
  4. Commits messages are according to this guideline
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-2499-cxx-14-for-hoofs-subset branch from a0f1b8a to be6b08a Compare October 23, 2025 13:50
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.87%. Comparing base (9e82c99) to head (2f6834a).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx_platform/linux/source/stdlib.cpp 78.04% 1 Missing and 8 partials ⚠️
iceoryx_platform/linux/source/acl_feature_on.cpp 75.00% 6 Missing ⚠️
..._reporting/custom/default/error_reporting_impl.hpp 66.66% 0 Missing and 3 partials ⚠️
iceoryx_platform/linux/source/_string.cpp 66.66% 2 Missing ⚠️
...eoryx_hoofs/utility/include/iox/detail/convert.inl 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   78.25%   77.87%   -0.38%     
==========================================
  Files         446      446              
  Lines       17107    16301     -806     
  Branches     2373     2320      -53     
==========================================
- Hits        13387    12695     -692     
+ Misses       2839     2759      -80     
+ Partials      881      847      -34     
Flag Coverage Δ
unittests 77.70% <78.12%> (-0.35%) ⬇️
unittests_timing 15.01% <2.08%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...concurrent/buffer/include/iox/detail/spsc_sofi.inl 91.83% <100.00%> (ø)
...er/include/iox/detail/fixed_position_container.inl 95.70% <ø> (ø)
...oryx_hoofs/container/include/iox/detail/vector.inl 96.31% <ø> (ø)
...container/include/iox/fixed_position_container.hpp 100.00% <100.00%> (ø)
...oofs/container/include/iox/uninitialized_array.hpp 100.00% <ø> (ø)
...design/include/iox/detail/move_and_copy_helper.inl 91.66% <ø> (ø)
...unctional/include/iox/detail/storable_function.hpp 100.00% <ø> (ø)
...ofs/posix/design/include/iox/detail/posix_call.inl 98.11% <ø> (ø)
...oryx_hoofs/posix/design/include/iox/posix_call.hpp 100.00% <ø> (ø)
...ceoryx_hoofs/primitives/include/iox/attributes.hpp 100.00% <ø> (ø)
... and 9 more

... and 172 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-2499-cxx-14-for-hoofs-subset branch from e0954f7 to 58b3dfb Compare October 24, 2025 09:13
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler changed the title [WIP] iox-#2499: C++14 support for 'iceoryx_hoofs' subset iox-#2499: C++14 support for 'iceoryx_hoofs' subset Oct 24, 2025
@elBoberido elBoberido force-pushed the iox-2499-cxx-14-for-hoofs-subset branch from 25585dd to 2e5d8ff Compare October 26, 2025 14:18
@elBoberido elBoberido force-pushed the iox-2499-cxx-14-for-hoofs-subset branch from 2e5d8ff to 890a642 Compare October 26, 2025 15:23
@elBoberido elBoberido merged commit f93a0e6 into eclipse-iceoryx:main Oct 26, 2025
46 of 58 checks passed
@elBoberido elBoberido deleted the iox-2499-cxx-14-for-hoofs-subset branch October 26, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++14 support for 'iceoryx_hoofs' subset

2 participants