Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 2, 2025

Notes for Reviewer

This PR relicenses the files in iceoryx_platform, iceoryx_hoofs, tools/ci, tools/git-hoods and tools/scripts are licensed as Apache-2.0 or MIT.

See #2491 for more details

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.87%. Comparing base (f93a0e6) to head (0dd1679).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2503   +/-   ##
=======================================
  Coverage   77.86%   77.87%           
=======================================
  Files         446      446           
  Lines       16301    16301           
  Branches     2320     2320           
=======================================
+ Hits        12693    12694    +1     
  Misses       2759     2759           
+ Partials      849      848    -1     
Flag Coverage Δ
unittests 77.70% <ø> (+<0.01%) ⬆️
unittests_timing 15.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx_hoofs/buffer/include/iox/detail/stack.inl 94.02% <ø> (ø)
iceoryx_hoofs/buffer/include/iox/stack.hpp 100.00% <ø> (ø)
iceoryx_hoofs/cli/include/iox/cli/arguments.inl 58.82% <ø> (ø)
...yx_hoofs/cli/include/iox/cli/option_definition.hpp 0.00% <ø> (ø)
...eoryx_hoofs/cli/include/iox/cli/option_manager.inl 73.33% <ø> (ø)
iceoryx_hoofs/cli/source/arguments.cpp 100.00% <ø> (ø)
iceoryx_hoofs/cli/source/command_line_parser.cpp 95.34% <ø> (ø)
iceoryx_hoofs/cli/source/option.cpp 96.77% <ø> (ø)
iceoryx_hoofs/cli/source/option_definition.cpp 100.00% <ø> (ø)
iceoryx_hoofs/cli/source/option_manager.cpp 81.81% <ø> (ø)
... and 138 more

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido merged commit b160b57 into eclipse-iceoryx:main Nov 2, 2025
24 checks passed
@elBoberido elBoberido deleted the iox-2491-relicense-iceoryx_platform-iceoryx_hoofs-scripts-ci-and-git-hooks branch November 2, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relicense iceoryx_hoofs, iceoryx_platform, scripts, CI setup and git hooks from "Apache-2.0" to "Apache-2.0 or MIT" (dual license)

2 participants