Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 2, 2025

Notes for Reviewer

Bump the version to v2.95.8 to make the C++14 hoofs subset available to iceoryx2 .

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. [~] Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from dkroenke November 2, 2025 11:18
Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.88%. Comparing base (b160b57) to head (37fcf44).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   77.87%   77.88%   +0.01%     
==========================================
  Files         446      446              
  Lines       16301    16301              
  Branches     2320     2320              
==========================================
+ Hits        12694    12696       +2     
  Misses       2759     2759              
+ Partials      848      846       -2     
Flag Coverage Δ
unittests 77.71% <ø> (+0.01%) ⬆️
unittests_timing 15.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido merged commit ffd3610 into eclipse-iceoryx:main Nov 2, 2025
104 of 109 checks passed
@elBoberido elBoberido deleted the iox-1295-bump-version-to-2.95.8 branch November 2, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants