Skip to content

Conversation

@dkroenke
Copy link
Member

Notes for Reviewer

With this Pull-Request we migrate the C# Language Binding authored by @patdhlk from https://github.com/patdhlk/iceoryx2-csharp main branch on commit patdhlk/iceoryx2-csharp@c625459 into this repository.

Please take a look and feel free to test it! There is a good written documentation and practical examples to check out.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (csharp-iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Relates #1

patdhlk and others added 22 commits October 28, 2025 14:05
update workflow documentation formatting.
- Updated README.md to include new features: Service Discovery and Domain Isolation.
- Expanded core concepts section with detailed explanations on Zero-Copy Shared Memory, Services and Communication Patterns, Nodes, Data Type Requirements, and Domain Isolation.
- Added new examples for WaitSet Event Multiplexing and Service Discovery, demonstrating efficient event handling and dynamic service discovery.
- Introduced NOTICE.md files in examples and src directories to clarify copyright and licensing information.
- Improved service configuration documentation with detailed examples for Publish-Subscribe, Publisher, and Subscriber configurations.
…rp-iox-1-migrate-csharp-binding-to-eclipse-iceoryx
@dkroenke dkroenke self-assigned this Dec 18, 2025
@dkroenke
Copy link
Member Author

@patdhlk Would you update the ECA on Eclipse with your mail address for the ECA Check in CI? http://www.eclipse.org/legal/ECA.php

@patdhlk
Copy link
Contributor

patdhlk commented Dec 18, 2025

@patdhlk Would you update the ECA on Eclipse with your mail address for the ECA Check in CI? http://www.eclipse.org/legal/ECA.php

✅ done

@dkroenke dkroenke closed this Dec 18, 2025
@dkroenke dkroenke reopened this Dec 18, 2025
@dkroenke dkroenke closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants