[#996] Use NonNull<u8> in elementary/BumpAllocator#1319
Draft
dkroenke wants to merge 3 commits intoeclipse-iceoryx:mainfrom
Draft
[#996] Use NonNull<u8> in elementary/BumpAllocator#1319dkroenke wants to merge 3 commits intoeclipse-iceoryx:mainfrom
NonNull<u8> in elementary/BumpAllocator#1319dkroenke wants to merge 3 commits intoeclipse-iceoryx:mainfrom
Conversation
NonNull<u8> in 'elementary/BumpAllocator'NonNull<u8> in elementary/BumpAllocator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
+ Coverage 77.82% 77.86% +0.04%
==========================================
Files 404 404
Lines 38684 38721 +37
Branches 1256 1256
==========================================
+ Hits 30106 30152 +46
+ Misses 7545 7536 -9
Partials 1033 1033
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Use NonNull<u8> for the pointer to the memory on construction and add a size parameter. Removed the atomic primitives.
78652ad to
c81ef5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
NonNull<u8>for start adress in 'BumpAllocator'NonNull<u8>for start argument innew()and return anOption<BumpAllocator>Pre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)PR Reviewer Reminders
References
Closes #996