Skip to content

[#996] Use NonNull<u8> in elementary/BumpAllocator#1319

Draft
dkroenke wants to merge 3 commits intoeclipse-iceoryx:mainfrom
ekxide:iox2-996-use-nonnull-in-elementary-bump-allocator
Draft

[#996] Use NonNull<u8> in elementary/BumpAllocator#1319
dkroenke wants to merge 3 commits intoeclipse-iceoryx:mainfrom
ekxide:iox2-996-use-nonnull-in-elementary-bump-allocator

Conversation

@dkroenke
Copy link
Contributor

Notes for Reviewer

  • Use NonNull<u8> for start adress in 'BumpAllocator'
  • Expect NonNull<u8> for start argument in new() and return an Option<BumpAllocator>

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #996

@dkroenke dkroenke requested a review from elBoberido January 23, 2026 13:47
@dkroenke dkroenke self-assigned this Jan 23, 2026
@dkroenke dkroenke changed the title [#996] Use NonNull<u8> in 'elementary/BumpAllocator' [#996] Use NonNull<u8> in elementary/BumpAllocator Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.86%. Comparing base (3021e90) to head (9497c8c).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
+ Coverage   77.82%   77.86%   +0.04%     
==========================================
  Files         404      404              
  Lines       38684    38721      +37     
  Branches     1256     1256              
==========================================
+ Hits        30106    30152      +46     
+ Misses       7545     7536       -9     
  Partials     1033     1033              
Flag Coverage Δ
CPP 68.04% <ø> (ø)
Rust 77.71% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/container/src/flatmap.rs 79.71% <100.00%> (+0.29%) ⬆️
iceoryx2-bb/container/src/queue.rs 90.43% <100.00%> (+0.19%) ⬆️
iceoryx2-bb/container/src/slotmap.rs 90.10% <100.00%> (+0.16%) ⬆️
...ryx2-bb/container/src/string/relocatable_string.rs 69.07% <ø> (ø)
...ceoryx2-bb/container/src/vector/relocatable_vec.rs 81.72% <ø> (ø)
iceoryx2-bb/elementary/src/bump_allocator.rs 100.00% <100.00%> (ø)
iceoryx2-bb/lock-free/src/mpmc/bit_set.rs 94.96% <100.00%> (+0.09%) ⬆️
iceoryx2-bb/lock-free/src/mpmc/container.rs 95.47% <100.00%> (+0.06%) ⬆️
iceoryx2-bb/lock-free/src/mpmc/unique_index_set.rs 93.00% <100.00%> (+0.05%) ⬆️
iceoryx2-bb/lock-free/src/spsc/index_queue.rs 85.40% <100.00%> (+0.24%) ⬆️
... and 3 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkroenke dkroenke marked this pull request as draft January 23, 2026 21:58
Use NonNull<u8> for the pointer to the memory on construction and add a
size parameter. Removed the atomic primitives.
@dkroenke dkroenke force-pushed the iox2-996-use-nonnull-in-elementary-bump-allocator branch 2 times, most recently from 78652ad to c81ef5c Compare February 12, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use 'NonNull' in 'elementary/BumpAllocator'

1 participant