Conversation
elBoberido
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Since we are targeting the safety domain, we need to follow some formalism. One is to always have commits referring to an issue number. For documentation fixes, we have a generic issue (#4). Can you please change the commit message to [#4] Correct documentation typo?
Please also do not delete the content of the PR template. This gives you and also the committer instructions on what do check during the PR. I'll recreate it for you.
|
@cerdelen did you already sign the ECA? If you already did, it takes a bit until everything is synced, so we just have to wait a little bit. |
|
@elBoberido I actually just did it a few min ago. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 77.83% 77.81% -0.02%
==========================================
Files 412 412
Lines 39008 39008
Branches 1256 1256
==========================================
- Hits 30360 30355 -5
- Misses 7615 7620 +5
Partials 1033 1033
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@cerdelen the ECA check can still do not find your account. Maybe it just takes longer than expected but just in case, you registered with the same email address you used for the commits, right? |
|
Oh i think the problem is that my email address on github is written with a '.' and eclipse doesn't like that so i used it without dot (which still leads to the same email account). |
|
@cerdelen it must match exactly the email address you used in your commits, else the ECA check will fail. |
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)PR Reviewer Reminders
References
Relates to #4