[23] DOM Support for implicitly declared classes

[subyssurendran666]

What it does

How to test

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[stephan-herrmann]

@mpalat @subyssurendran666 Changes on ASTConverter_23Test here and in #3252 (@jarthana fyi) cause issues when merging into BETA_JAVA24, notably because in the other branch this file has been renamed! (resulting status: compile errors after the merge - I've fixed those as part of #3551).

From a systematic point of view, implicitly declared classes are still in preview. So shouldn't we make all changes regarding this feature in the beta branch??

[mpalat]

From a systematic point of view, implicitly declared classes are still in preview. So shouldn't we make all changes regarding this feature in the beta branch??

@stephan-herrmann Since this was applicable in master as well it was pushed to master. For example, issues in primitive types in pattern, we have pushed to master rather than Beta. However, I agree with you that from a systematic point of view, we can discuss and fix a method. I would think that:

1. non-API changes of the preview features which can go into master if the issue owner wishes so and if it doesn't create any merge issues and failures and API changes (like this one) can go to BETA.
2. Or as you mentioned, all changes can goto preview.

I agree that the second option is more uniform and zero-confusion and maybe easier to follow for everyone. If the general consensus is that this is better we can go alongwith this option.

@jarthana any comments from your side?