Skip to content

Regression test for https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3319 #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikanth-sankaran merged 1 commit into from
Dec 4, 2024
Merged

Regression test for https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3319 #3391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions ...ts.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/NullAnnotationTests21.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,4 +1280,87 @@ void goo() {
""";
runner.runNegativeTest();
}

// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3319
// [Enhanced Switch][Null] Inconsistent nullness propagation
public void testIssue3319() {
Runner runner = getDefaultRunner();
runner.testFiles = new String[] {
"X.java",
"""
import org.eclipse.jdt.annotation.NonNull;

public class X {
static @NonNull Object foo(Object o) {
switch (o) {
case String s -> {
if (o == null) {
System.out.println("o cannot be null at all!");
}
System.out.println();
}
default -> {
if (o == null) {
System.out.println("o cannot be null at all!");
}
System.out.println();
}
}
return new Object();
}

static @NonNull Object foo(X o) {
switch (o) {
case X s -> {
if (o == null) {
System.out.println("o cannot be null at all!");
}
System.out.println(s);
}
}
return new Object();
}
}
"""
};
runner.expectedCompilerLog =
"----------\n" +
"1. ERROR in X.java (at line 7)\n" +
" if (o == null) {\n" +
" ^\n" +
"Null comparison always yields false: The variable o cannot be null at this location\n" +
"----------\n" +
"2. WARNING in X.java (at line 7)\n" +
" if (o == null) {\n" +
" System.out.println(\"o cannot be null at all!\");\n" +
" }\n" +
" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
"Dead code\n" +
"----------\n" +
"3. ERROR in X.java (at line 13)\n" +
" if (o == null) {\n" +
" ^\n" +
"Null comparison always yields false: The variable o cannot be null at this location\n" +
"----------\n" +
"4. WARNING in X.java (at line 13)\n" +
" if (o == null) {\n" +
" System.out.println(\"o cannot be null at all!\");\n" +
" }\n" +
" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
"Dead code\n" +
"----------\n" +
"5. ERROR in X.java (at line 25)\n" +
" if (o == null) {\n" +
" ^\n" +
"Null comparison always yields false: The variable o cannot be null at this location\n" +
"----------\n" +
"6. WARNING in X.java (at line 25)\n" +
" if (o == null) {\n" +
" System.out.println(\"o cannot be null at all!\");\n" +
" }\n" +
" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" +
"Dead code\n" +
"----------\n";
runner.runNegativeTest();
}
}
Loading