Skip to content

Conversation

@jarthana
Copy link
Member

What it does

Fixes #3943

How to test

Author checklist

@jarthana jarthana marked this pull request as draft April 22, 2025 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

Test Results

    11 files  +  3      11 suites  +3   18m 17s ⏱️ +38s
79 450 tests +125  79 450 ✅ +156  0 💤 ±0  0 ❌  - 31 
79 510 runs  +125  79 510 ✅ +156  0 💤 ±0  0 ❌  - 31 

Results for commit 5a12e44. ± Comparison against base commit 6798c4b.

♻️ This comment has been updated with latest results.

@jarthana jarthana marked this pull request as ready for review May 6, 2025 06:12
@jarthana jarthana force-pushed the gh3943 branch 2 times, most recently from fbcc317 to e903739 Compare May 6, 2025 07:54
@jarthana jarthana merged commit 80f6ed7 into master May 7, 2025
16 checks passed
@jarthana jarthana deleted the gh3943 branch May 7, 2025 05:41
@stephan-herrmann
Copy link
Contributor

stephan-herrmann commented Nov 27, 2025

@jarthana has this change ever been tested at compliance 16?

In Y-builds I found PreviewFeatureTest.test001 and test002 to fail at compliance 16, see https://download.eclipse.org/eclipse/downloads/drops4/Y20251125-1000/testresults/html/org.eclipse.jdt.core.tests.compiler_ep438Y-unit-linux-x86_64-java26_linux.gtk.x86_64_26.html

Looking at current I-builds, we simply do not execute these two tests because:

  • below 16 the entire test class is skipped
  • above 16 those particular tests are skipped :)

OTOH, this raises the question, where are compliance levels specified for Y-build tests? Looks like tests are run for all from 1.8 to 26, which is more than we need, but at least it revealed this issue in PreviewFeatureTest.

@stephan-herrmann
Copy link
Contributor

stephan-herrmann commented Nov 27, 2025

OTOH, this raises the question, where are compliance levels specified for Y-build tests? Looks like tests are run for all from 1.8 to 26, which is more than we need, but at least it revealed this issue in PreviewFeatureTest.

This one I found: test.xml lacks a definition -Dcompliance.jre.26=... -> over to #4658

@jarthana
Copy link
Member Author

jarthana commented Dec 1, 2025

@jarthana has this change ever been tested at compliance 16?

In Y-builds I found PreviewFeatureTest.test001 and test002 to fail at compliance 16, see https://download.eclipse.org/eclipse/downloads/drops4/Y20251125-1000/testresults/html/org.eclipse.jdt.core.tests.compiler_ep438Y-unit-linux-x86_64-java26_linux.gtk.x86_64_26.html

Looking at current I-builds, we simply do not execute these two tests because:

* below 16 the entire test class is skipped

* above 16 those particular tests are skipped :)

I don't remember the history now. Sorry, poor memory. But this test has been a pain to maintain since the preview APIs keep changing, getting removed etc. But still should be consistent if --release is effective.

Anyway, thanks for reporting it. I have a PR here for this - #4666

@jarthana
Copy link
Member Author

jarthana commented Dec 1, 2025

The cause still remains though. Even now, with selective compliance and some suites or tests only run at particular levels, there could be other tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unresolvable "This API is part of the preview feature ... which is disabled by default" error

3 participants