-
Notifications
You must be signed in to change notification settings - Fork 160
NonNullByDefault: provide exact syntax for turning it off #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NonNullByDefault: provide exact syntax for turning it off #4512
Conversation
|
@dilyanpalauzov : thanks for the PR. |
|
I am not going to submit anything further, to what I did. I do not have the time to read what ECA means. Take the current change as a gift. If you do not like the gift, throw it in the garbage. |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Eclipse Contributor Agreement. Without ECA signed, no code can be accepted, sorry. |
|
This is non-sense. If I fill a ticket and as a result somebody does the identical change, then it will be perfectly fine. However it will be more work, compared to just accepting this change. First I have to invest time to create a ticket and then somebody has to invest time to fix the report, in the same way I did, and close the ticket. I personally have no interest neither if this is fixed, nor in filling a ticket. Accepting this change is beneficial not for me, but for a broader group of persons. In this concrete case ECA rules do not serve a legitimate purpose, but end in theirselves. |
It is not disputable. No code can be accepted without ECA signed. |
I had difficulties fighting with the compiler and once I found out that
@NonNullByDefaultcan be switched off for a small scope, I tried with many syntaxes:@NonNullByDefault(value=false),@NonNullByDefault(false)and others, until I found the exact syntax.For people who regularly use Java the current documentation is probably very good, but for others, who have to fight with the compiler, this addition will be very welcomed.