Pass FORCE_PROBLEM_DETECTION from reconcile to CompilationUnitResolver #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through ASTParser. The ASTParser implementation may trigger extra analysis on demand. The FORCE_PROBLEM_DETECTION flag must be somehow passed to underlying ICompilationUnitResolver implementation to allow that. Fixes eclipse-jdt#4631
Contributor
Author
|
@rgrunber @jjohnstn @datho7561 Could any of you review (snd merge if appropriate) this path? |
Contributor
Author
|
This addition would have a huge impact on the Javac integration (boosting both correctness and performance), and has no effect on the regular execution flow. The proposed API is (IMO) very safe. |
rgrunber
approved these changes
Nov 17, 2025
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through ASTParser.
What it does
The ASTParser implementation may trigger extra analysis on demand. The FORCE_PROBLEM_DETECTION flag must be somehow passed to underlying ICompilationUnitResolver implementation to allow that.
Fixes #4631
How to test
See it in combination with eclipse-jdtls#1879 which clarifies that this flag is necessary to make some tests pass with a DOM-based approach.
Author checklist