fixes the record type inference issue #4643

[mpalat]

What it does

Fixes the Record Type Inference issue as mentioned in #4643

How to test

Two test cases mentioned in the issue can be tried to check the fix. These test cases have been coded as unit test cases as well in the PR.

Fix is to do the component resolution once the record type inference is done, set the outer expression type and then call the resolution on patterns .

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[mpalat]

@stephan-herrmann can you please do a quick review of this? Checking whether we can push it for RC2?

[srikanth-sankaran]

Can we check how far back the current behavior goes ? Unless this is a regression introduced in 4.38 we may want to wait and release this as soon as 4.39 opens for development

[mpalat]

Can we check how far back the current behavior goes ? Unless this is a regression introduced in 4.38 we may want to wait and release this as soon as 4.39 opens for development

sure @srikanth-sankaran. We can wait for 4.39 M1 as well. This issue is not a regression introduced in 4.38 and has been there (in 4.37 and 4.36).

@stephan-herrmann - Please chime in if you prefer this to go in 4.38.

[stephan-herrmann]

Change looks good to me: every attempt to resolve a pattern should first set outerExpressionType (field exists under this name since #2878 / BETA_JAVA23).