Defer workspace operations until workspace service is started #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
commented
Apr 29, 2025
| return null; | ||
| } | ||
| try { | ||
| InstanceScope.INSTANCE.getNode(ID_PLUGIN).addPreferenceChangeListener(LaunchingPlugin.this); |
Contributor
Author
There was a problem hiding this comment.
@iloveeclipse What is the proper way to defer calling this until it has been set? The default eclipse.ini sets -Dosgi.dataAreaRequiresExplicitInit=true i.e. may run into https://github.com/eclipse-equinox/equinox/blob/c6f8e3aab8d4f107d7836f21a2fc76823756ad73/bundles/org.eclipse.equinox.common/src/org/eclipse/core/internal/runtime/DataArea.java#L64
Contributor
Author
There was a problem hiding this comment.
Ok meanwhile found the relevant OSGi services:
g! services org.eclipse.osgi.service.datalocation.Location
{org.eclipse.osgi.service.datalocation.Location}={service.id=7, service.bundleid=0, service.scope=singleton, defaultUrl=file:/Users/715508/user/, url=file:/Users/715508/user/, type=osgi.user.area}
"Registered by bundle:" org.eclipse.osgi_3.23.0.v20250228-0640 [0]
"Bundles using service"
org.eclipse.core.runtime_3.33.0.v20250206-0919 [199]
{org.eclipse.osgi.service.datalocation.Location}={service.id=8, service.bundleid=0, service.scope=singleton, defaultUrl=file:/Users/715508/eclipse-workspace/, url=file:/Users/715508/eclipse-workspaces/maven/, type=osgi.instance.area}
"Registered by bundle:" org.eclipse.osgi_3.23.0.v20250228-0640 [0]
"Bundles using service"
org.eclipse.core.runtime_3.33.0.v20250206-0919 [199]
org.eclipse.equinox.preferences_3.11.300.v20250130-0533 [457]
org.eclipse.equinox.common_3.20.0.v20250129-1348 [413]
org.eclipse.core.resources_3.22.100.v20250206-1238 [198]
org.eclipse.e4.ui.workbench.swt_0.17.700.v20250123-0706 [355]
org.eclipse.core.net_1.5.600.v20250124-0919 [197]
{org.eclipse.osgi.service.datalocation.Location}={service.id=9, service.bundleid=0, service.scope=singleton, url=file:/Users/715508/Applications/Eclipse/aem-2025-03/Eclipse.app/Contents/Eclipse/configuration/, type=osgi.configuration.area}
"Registered by bundle:" org.eclipse.osgi_3.23.0.v20250228-0640 [0]
"Bundles using service"
org.eclipse.core.runtime_3.33.0.v20250206-0919 [199]
org.eclipse.equinox.registry_3.12.300.v20250129-1129 [458]
org.eclipse.equinox.preferences_3.11.300.v20250130-0533 [457]
org.eclipse.equinox.app_1.7.300.v20250130-0528 [411]
org.eclipse.update.configurator_3.5.600.v20241215-0811 [897]
{org.eclipse.osgi.service.datalocation.Location}={service.id=10, service.bundleid=0, service.scope=singleton, url=file:/Users/715508/Applications/Eclipse/aem-2025-03/Eclipse.app/Contents/Eclipse/, type=osgi.install.area}
"Registered by bundle:" org.eclipse.osgi_3.23.0.v20250228-0640 [0]
"Bundles using service"
org.eclipse.osgi_3.23.0.v20250228-0640 [0]
org.eclipse.equinox.common_3.20.0.v20250129-1348 [413]
org.eclipse.core.runtime_3.33.0.v20250206-0919 [199]
org.eclipse.update.configurator_3.5.600.v20241215-0811 [897]
{org.eclipse.osgi.service.datalocation.Location}={service.id=11, service.bundleid=0, service.scope=singleton, url=file:/Users/715508/Applications/Eclipse/aem-2025-03/Eclipse.app/Contents/Eclipse/, type=eclipse.home.location}
"Registered by bundle:" org.eclipse.osgi_3.23.0.v20250228-0640 [0]
"No bundles using service."
Seems we need to wait for service org.eclipse.osgi.service.datalocation.Location of type type=osgi.instance.area until it is safe to call InstanceScope.INSTANCE.getNode(...)
Contributor
Author
|
Superseded by #686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #684
What it does
How to test
Author checklist