Preserve last code minings for non-reconciled viewers and clean up on viewer disposal #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viewer disposal - Cache the last calculated `ICodeMining` list per `ITextViewer` and return it when the viewer is not yet reconciled instead of an empty list. - Track viewers with a synchronized `Set` and lazily attach a `DisposeListener` to their `StyledText` widgets to remove cached minings and listener state on disposal. - Ensure thread safety around listener installation using synchronization and `Display.asyncExec`, while keeping map updates simple and non-blocking. This improves the user experience by preventing code minings from flickering or disappearing during reconciliation delays, while properly managing memory through cleanup on viewer disposal. Fixes: eclipse-platform/eclipse.platform.ui#2786 (comment)
Contributor
Author
|
replaced by #2698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICodeMininglist perITextViewerand returnit when the viewer is not yet reconciled instead of an empty list.
Setand lazily attach aDisposeListenerto their
StyledTextwidgets to remove cached minings and listener stateon disposal.
and
Display.asyncExec, while keeping map updates simple and non-blocking.This improves the user experience by preventing code minings from flickering
or disappearing during reconciliation delays, while properly managing memory
through cleanup on viewer disposal.
Fixes: eclipse-platform/eclipse.platform.ui#2786 (comment)