Remove access to `CompletionEngine.completionToken`#1128

Open

datho7561 wants to merge 895 commits intoeclipse-jdtls:dom-with-javacfrom

datho7561:dom-with-javac-dont-use-completion-token

This pull request is big! We're only showing the most recent 250 commits

Commits on Jan 22, 2025

Reverting removal of suspected typo, was not typo, was part of test

Rob Stryker
authored and
datho7561
committed
Cache JCCompilationUnit from compilation job for reuse in problem converter (#853)

testforstephen
authored and
datho7561
committed
Fix some javadoc issue mapping

mickaelistria
authored and
datho7561
committed
Set AccDeprected flag at DOM level

mickaelistria
authored and
datho7561
committed
Fix `ClassCastException` when working with module projects
datho7561
committed
Completion to add override for inherited method
datho7561
committed
Improvements to variable and method completion in method bodies
datho7561
committed
Handle incomplete qualified names
datho7561
committed
Completion on `super.`
datho7561
committed
Map a problem id related to `super()`
datho7561
committed
Method argument completion
datho7561
committed
Improve annotation completion
datho7561
committed
Set debug info parameters (-g) to javac compiler

testforstephen
authored and
datho7561
committed
Enable completion tests
datho7561
committed
Fix some completion relevances
datho7561
committed
Completion for keywords that can be inserted where statements can
datho7561
committed
Add cancellation checks to DOMCompletionEngine
datho7561
committed
Compile the generated sources into the expected target directory (#879)

testforstephen
authored and
datho7561
committed
ASTConverter15JLS4Test.test0155 through test0160 - boxing and unboxing

Rob Stryker
authored and
datho7561
committed
Add some problem mapping

Rob Stryker
authored and
datho7561
committed
More test annotations

Rob Stryker
authored and
datho7561
committed
index out of bounds exception

Rob Stryker
authored and
datho7561
committed
test0050/X.java - Cleaner handling of variable arity signatures

Rob Stryker
authored and
datho7561
committed
Ensure parent packages are added to bindings

Rob Stryker
authored and
datho7561
committed
Cleanup

Rob Stryker
authored and
datho7561
committed
Begin reporting on completion progress monitor
datho7561
committed
Mark the completion task as done using the progress monitor
datho7561
committed
Share/deduplicate jar contents

mickaelistria
authored and
datho7561
committed
Fix test0080 - generics vs raw vs parameterized

Rob Stryker
authored and
datho7561
committed
Fix test0164 - getDeclaringMethod() should return the declaration binding

Rob Stryker
authored and
datho7561
committed
Use one default completion strategy
datho7561
committed
Prevent error when renaming variable
datho7561
committed
Complete method return type, modifiers and thrown exceptions
datho7561
committed
Make MatchLocator capable of working with DOM

mickaelistria
authored and
datho7561
committed
JavacUtils.classpathEntriesToFiles doesn't configure dependent projects

snjeza
authored and
datho7561
committed
Improve field completion (`name.|`)
datho7561
committed
Fix some NPEs in completion
datho7561
committed
Avoid NumberFormatException when trying to get latest JRE.

mickaelistria
authored and
datho7561
committed
Really ignore compiler.warn.dangling.doc.comment

akurtakov
authored and
datho7561
committed
Some fixes to keyword completion
datho7561
committed
Prevent exception with multiline Javadoc method ref
datho7561
committed
Improve completion in extends/implements
datho7561
committed
Fixes to relevance and specific completion content
datho7561
committed
Map "compiler.warn.override.unchecked.ret"

akurtakov
authored and
datho7561
committed
Improve JavacBindingResolver

snjeza
authored and
datho7561
committed
Ignore 2 warnings without positions

akurtakov
authored and
datho7561
committed
Improve ClassInstanceCreation completion
datho7561
committed
Fix StringIndexOutOfBoundsException in Javadoc conversion

akurtakov
authored and
datho7561
committed
Remove false positive 'unused import' for import used in Javadoc
datho7561
committed
Field access and extends/implements completion improvements
datho7561
committed
Fix wrong unused import for throws javadoc

akurtakov
authored and
datho7561
committed
More fixes for field access
datho7561
committed
Better support for ASTParser.setFocalPoint()

mickaelistria
authored and
datho7561
committed
Do not generate false positive unused parameter warning

akurtakov
authored and
datho7561
committed
Fix some regressions caused by field access fix
datho7561
committed
Share the FileManager used when -release is set

mickaelistria
authored and
datho7561
committed
Manage prefix for extends and implements completion
datho7561
committed
Improve completion for annotation members
datho7561
committed
No completion in strings, text blocks, comments, or Javadoc
datho7561
committed
Update doc

mickaelistria
authored and
datho7561
committed
Restore completion strategy switch

mickaelistria
authored and
datho7561
committed
Handle resolving bindings for generic constructors
datho7561
committed
Fix some errors that occur when importing o.e.j.c incubator
datho7561
committed
[WIP] double colon completion
datho7561
committed
Improve completion for binary infix operator
datho7561
committed
Ignoring Javadoc of depedencies

mickaelistria
authored and
datho7561
committed
Completion for Javadoc tags
datho7561
committed
Prevent from closing the Platform FileManager

mickaelistria
authored and
datho7561
committed
Reduce processing using -implicit:none

mickaelistria
authored and
datho7561
committed
Add output folders to classpath

mickaelistria
authored and
datho7561
committed
Skip linting without binding nor FORCE_PROBLEM_DETECTION

mickaelistria
authored and
datho7561
committed
Fix completion when typing out an import
datho7561
committed
Ignore Javadoc for compiler

mickaelistria
authored and
datho7561
committed
Do not lint when focusing on 1 particular position

mickaelistria
authored and
datho7561
committed
Use partial DOM for completion, and for codeSelect on bigger files

mickaelistria
authored and
datho7561
committed
Fix issue setting position of markdown comments

mickaelistria
authored and
datho7561
committed
Fix unconfigure in p2.inf

mickaelistria
authored and
datho7561
committed
Problem range for `IProblem.AbstractServiceImplementation`
datho7561
committed
Fix replace range for anonymous class instance creation
datho7561
committed
Handle adding semicolon properly for import completion
datho7561
committed
Completion on unimported class
datho7561
committed
Fix issue populating multiple output class folders

mickaelistria
authored and
datho7561
committed
Fix instruction.unconfigure

mickaelistria
authored and
datho7561
committed
Improve `throws` completion
datho7561
committed
Fix NPE when converting constructor without body
datho7561
committed
If outside the double quotes of a string literal, use the parent as the completion context
datho7561
committed
Some support for "proceedOnError"-like with javac

mickaelistria
authored and
datho7561
committed
Improve recovery on undefined method reference

mickaelistria
authored and
datho7561
committed
Avoid NPE when using completion for import QuickFix
datho7561
committed
Fix some CompletionContextTests

mickaelistria
authored and
datho7561
committed
Support unknown expr in instanceof

mickaelistria
authored and
datho7561
committed
Fix error popups when class extends itself
datho7561
committed
Make some match locator work with DOM

Rob Stryker
authored and
datho7561
committed
Fix some conversion/bindings

Rob Stryker
authored and
datho7561
committed
Keep string folding for build (not for CompilationUnitResolver)

mickaelistria
authored and
datho7561
committed
Suggest creating a new lambda when a funcitonal interface is needed
datho7561
committed
Enable compilation progress reporting and cancellation

mickaelistria
authored and
datho7561
committed
Revert "Fix error popups when class extends itself"

mickaelistria
authored and
datho7561
committed
Single pass compilation even with multiple source folders

mickaelistria
authored and
datho7561
committed
Fix possible IndexArrayOutOfBoundsError

mickaelistria
authored and
datho7561
committed
Expected type for ternary (`? :`)
datho7561
committed
Endless loop during testBug229951a

Rob Stryker
authored and
datho7561
committed
Fix testTypeParameterConstructors04 and others

Rob Stryker
authored and
datho7561
committed
Fix testStaticImportMethod03 and others

Rob Stryker
authored and
datho7561
committed
Fix testStaticImportField04

Rob Stryker
authored and
datho7561
committed
Fix testEnum05

Rob Stryker
authored and
datho7561
committed
Fix some NPEs

Rob Stryker
authored and
datho7561
committed
Fix testTypeReference35 - corrupt jar on cp

Rob Stryker
authored and
datho7561
committed
Fix NPE, convert 4 errors to fails

Rob Stryker
authored and
datho7561
committed
Historical merge error in javadoc, not new

Rob Stryker
authored and
datho7561
committed
Add output folder to classpath (#1006)

snjeza
authored and
datho7561
committed
Fix testTypeParameterConstructors01 and others

Rob Stryker
authored and
datho7561
committed
Fix testTypeDeclaration12 and others

Rob Stryker
authored and
datho7561
committed
Fix testTypeReference22

Rob Stryker
authored and
datho7561
committed
Do not close underlying channel for cached zip

mickaelistria
authored and
datho7561
committed
Fix execution of Javac test

mickaelistria
authored and
datho7561
committed
Fix testBuildReferenceOtherProjectSource

mickaelistria
authored and
datho7561
committed
Skip ProceedOnErrorTransTypes whenever possible

mickaelistria
authored and
datho7561
committed
More proceed on error: throw + var decl

mickaelistria
authored and
datho7561
committed
Bump parent version for org.eclipse.jdt.core.tests.javac

mickaelistria
authored and
datho7561
committed
Avoid NPE in DOMToModelConverter.toLocalVariable

mickaelistria
authored and
datho7561
committed
Prevent NPE in JavacBindingResolver

mickaelistria
authored and
datho7561
committed
Map compiler.err.limit.string & compiler.err.limit.string.overflow pb

mickaelistria
authored and
datho7561
committed
Bump version of org.eclipse.jdt.core

mickaelistria
authored and
datho7561
committed
Don't add import for `java.lang`
datho7561
committed
Include literal elements in literal

mickaelistria
authored and
datho7561
committed
Don't log possible syntax errors when editing

mickaelistria
authored and
datho7561
committed
Convert compiler.err.switch.mixing.case.types

mickaelistria
authored and
datho7561
committed
Some fixes to CompletionContextTests

mickaelistria
authored and
datho7561
committed
Don't adjust cursor offset when finding node to complete
datho7561
committed
Fix testBug251827b and 5 others - import declarations java element must be found

Rob Stryker
authored and
datho7561
committed
Fix some completionContextTests

mickaelistria
authored and
datho7561
committed
JavacConverter: Do not set/fix position for recovered names

mickaelistria
authored and
datho7561
committed
Fix some inner class not being copied

mickaelistria
authored and
datho7561
committed
Revert "Don't adjust cursor offset when finding node to complete"

mickaelistria
authored and
datho7561
committed
Fix some contextCompletionTests (to 73)

mickaelistria
authored and
datho7561
committed
Improve attached import completion for type completions
datho7561
committed
Some work on expected types (down to 49 failures)

mickaelistria
authored and
datho7561
committed
Fix more CompletionContextTests (down to 43)

mickaelistria
authored and
datho7561
committed
Handle match files in the order they arrived

Rob Stryker
authored and
datho7561
committed
Ensure all parent nodes fully encompass their child nodes

Rob Stryker
authored and
datho7561
committed
Ensure calls to ASTParser.createBindings use the correct unit resolver

Rob Stryker
authored and
datho7561
committed
null check before passing a new TypeBinding to requestor

Rob Stryker
authored and
datho7561
committed
Missing names must have length 0, not length 7 representing <error>

Rob Stryker
authored and
datho7561
committed
Fixes to VariableDeclaration completion
datho7561
committed
Handle qualification when calculating relevance
datho7561
committed
Do not double-propose types
datho7561
committed
Fix ASTConverter18Test.test0009 - illegal argument

Rob Stryker
authored and
datho7561
committed
Keep cached filesystems uniniterruptible

mickaelistria
authored and
datho7561
committed
Fix position for ArrayInitializer

mickaelistria
authored and
datho7561
committed
Fix NPE in testBug424138_001 and others; bad synchronized block

Rob Stryker
authored and
datho7561
committed
Fix regressions ASTConverterAST3Test.test0009 and others; also Cleanup

Rob Stryker
authored and
datho7561
committed
NPE check in DOMCompletionEngine when erasure is null

Rob Stryker
authored and
datho7561
committed
CompletionContextTest: null token after string literal

mickaelistria
authored and
datho7561
committed
Translate problem id for unknown annotation member
datho7561
committed
Fixes #1038 - regression during some error syntax

Rob Stryker
authored and
datho7561
committed
Used Resolved* JavaElement in Javac*Bindings.getJavaElement()

mickaelistria
authored and
datho7561
committed
javac doesn't configure output folders of dependent projects correctly

snjeza
authored and
datho7561
committed
Completion for favourite static imports
datho7561
committed
Camel case matching for completed types
datho7561
committed
Remove calls to jobs that are no longer needed.

rgrunber
authored and
datho7561
committed
Use resolved JavaElement from binding for CompletionContext.enclosing

mickaelistria
authored and
datho7561
committed
Ensure bindings are ordered by depth

mickaelistria
authored and
datho7561
committed
Use resolved key for binary elements too

mickaelistria
authored and
datho7561
committed
Strip exception from CompletionProposal.getSignature()

mickaelistria
authored and
datho7561
committed
Fixes CompletionContextTests.test0004 and possibly others

Rob Stryker
authored and
datho7561
committed
Improve method and type key

mickaelistria
authored and
datho7561
committed
Add boolean to ExpectedTypes when in conditions

mickaelistria
authored and
datho7561
committed
New method completion proposal
datho7561
committed
add 1-click install link

mickaelistria
authored and
datho7561
committed
Add feature for javac

mickaelistria
authored and
datho7561
committed
Enable lombok with javac

snjeza
authored and
datho7561
committed
Fix expected type for return statements
datho7561
committed
Constructor invocation completion proposal improvements
datho7561
committed
Fixes to completing types
datho7561
committed
Fix test0008 and others: empty block comment misunderstood by javac as block comment

Rob Stryker
authored and
datho7561
committed
Make for fileObjects uninterruptible

mickaelistria
authored and
datho7561
committed
Set NON_INHERITED on relevance

mickaelistria
authored and
datho7561
committed
Force setAccessible in reflection

mickaelistria
authored and
datho7561
committed
Do not suggest .class .super .this suffix for types

mickaelistria
authored and
datho7561
committed
Open java.compiler/javax.tools=ALL-UNNAMED

mickaelistria
authored and
datho7561
committed
Fix possible Javadoc parsing issue for reused nodes

mickaelistria
authored and
datho7561
committed
Add javac feature to 2nd build step

mickaelistria
authored and
datho7561
committed
Cleanup and disable 3 tests

Rob Stryker
authored and
datho7561
committed
Fix CompletionContextTests.test0116 and 1 other

Rob Stryker
authored and
datho7561
committed
Add javax.tools to o.e.j.c.tests.javac

snjeza
authored and
datho7561
committed
Fix ASTConverter15JLS4Test.test0008

snjeza
authored and
datho7561
committed
Integrate javac library with a standalone bundle

testforstephen
authored and
datho7561
committed
Completion for `import module |;`
datho7561
committed
`@param |` completion
datho7561
committed
Add support for packages in completion

mickaelistria
authored and
datho7561
committed
Do not create invalid JavacVariableBinding

mickaelistria
authored and
datho7561
committed
Fix modifiers for types when coming from AST

mickaelistria
authored and
datho7561
committed
Filter proposed packages

mickaelistria
authored and
datho7561
committed
Add completion of package keyword

mickaelistria
authored and
datho7561
committed
Prevent NPE

mickaelistria
authored and
datho7561
committed
Fix some JavacTypeBinding.getKey with generic extends

mickaelistria
authored and
datho7561
committed
Resolve type for name when possible

mickaelistria
authored and
datho7561
committed
Improve JavacMethodBinding.isRaw

mickaelistria
authored and
datho7561
committed
Fix to ExpectedTypes

mickaelistria
authored and
datho7561
committed
Fix various warnings

akurtakov
authored and
datho7561
committed
Fix various possible NPEs

mickaelistria
authored and
datho7561
committed
Update README with updated args

mickaelistria
authored and
datho7561
committed
Remove unused methods from JavacBindingResolver

akurtakov
authored and
datho7561
committed
Error IDs for problems unique to javac
datho7561
committed
Add NON_STATIC to relevance

mickaelistria
authored and
datho7561
committed
Do not insert classname for static methods inside expression

mickaelistria
authored and
datho7561
committed
Fixes to Javadoc completion
datho7561
committed
Add java.base/sun.nio.ch=ALL-UNNAMED to arguments

akurtakov
authored and
datho7561
committed
Implement completion for field ref in Javadoc
datho7561
committed
Some work on type completion

mickaelistria
authored and
datho7561
committed
Improvements to completion

mickaelistria
authored and
datho7561
committed
Improve relevance computation for annotation without @Target

mickaelistria
authored and
datho7561
committed
Improve some import static type completion

mickaelistria
authored and
datho7561
committed
Work on completion with static import

mickaelistria
authored and
datho7561
committed
Completion for method references in javadoc
datho7561
committed
Record junit issues and warn on increase

akurtakov
authored and
datho7561
committed
More support for annotation value names

mickaelistria
authored and
datho7561
committed
Improve support for completing enum constants in switch case

mickaelistria
authored and
datho7561
committed
Publish all issues in Jenkins

akurtakov
authored and
datho7561
committed
Fix unused import

akurtakov
authored and
datho7561
committed
Obey SuppressWarnings("removal") in unused detector

akurtakov
authored and
datho7561
committed
Unused imports are always listed as errors

snjeza
authored and
datho7561
committed
Test case for PR #1139

snjeza
authored and
datho7561
committed
Collect `instanceof` and switch pattern variable bindings
datho7561
committed
Improve converter & binding for IMemberValuePair

mickaelistria
authored and
datho7561
committed
NPE in binding resolver

Rob Stryker
authored and
datho7561
committed
Set range for missing name anyway

mickaelistria
authored and
datho7561
committed
Fixes 1145 - don't make a position when length is invalid

Rob Stryker
authored and
datho7561
committed
Unnecessary import

Rob Stryker
authored and
datho7561
committed
Improve expectType for ArrayInitializer

mickaelistria
authored and
datho7561
committed
Fix some relevance for member dereference

mickaelistria
authored and
datho7561
committed
Improve some proceedOnError generation

mickaelistria
authored and
datho7561
committed
Map compiler.warn.override.varargs.missing

akurtakov
authored and
datho7561
committed
Fixes #1155 - remove all ClassCastException in error log after importing org.eclipse.pde.ui

Rob Stryker
authored and
datho7561
committed
Ignore diagnostics without positions

akurtakov
authored and
datho7561
committed
Fix failures of GHAs in local forks

akurtakov
authored and
datho7561
committed
Map one more varargs diagnostic

akurtakov
authored and
datho7561
committed

Commits on Jan 23, 2025

Commits on Jan 24, 2025

Fixes #1170 - missing diagnostic constant

Rob Stryker
authored and
mickaelistria
committed
Dogfooding the pde project has revealed several NPEs

Rob Stryker
authored and
mickaelistria
committed
Test for release
mickaelistria
committed
Use JavaTask in JavaCompiler
mickaelistria
committed
Forward release setting to AbstractImageBuilder
mickaelistria
committed
Extension point to replace `CompletionEngine`

datho7561
authored and
mickaelistria
committed
Completion for pattern variable initialized in for loop expression
datho7561
committed
Remove access to `CompletionEngine.completionToken`
datho7561
committed
Remove dependency on CompletionEngine, excepting static methods

Rob Stryker
authored and
datho7561
committed