Restore comparingsearch level #1546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
restore-comparingsearch-level
branch
from
22c76b5 to
31ed617
Compare
|
I'd like to see failures down a bit more before we go doing this, but it's ultimately up to you. |
Author
|
I agree, I was expecting a bit less than a hundred failures, but it's much more. I am targetting a merge when the extra failures are up by 100 or less. |
mickaelistria
force-pushed
the
restore-comparingsearch-level
branch
4 times, most recently
from
999cd3e to
bf60323
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
73d28b4 to
aa8f401
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
4082278 to
ebc593c
Compare
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
eg. there should be no keywords when completing at the `|`
```java
int[] a = new int[] { | };
```
Signed-off-by: David Thompson <[email protected]>
Fixes eclipse-jdtls#1394 Fixes eclipse-jdtls#1395
Instead of always re-reading the jars for symbols, we create a local cache that is capable of recreating the symbol into any context reliably enough from memory. This should drastically improve performance.
* ForAll/generic methods
* Synchronize init of reflection * Do not share the signatureBuffer, keep it instance specific to avoid concurrent modification. Sharing doesn't bring any benefit anyway.
A parser may decide to keep a TextElement as " blah" with (offset, length)=(N,5); or as "blah" with (offset,length)=(N+1,4). Both are valid. Make test tolerate both.
The parent EnumConstantDeclaration is already checked, no need to re-check the name.
I disagree personally but this is what JDT does. Signed-off-by: David Thompson <[email protected]>
mickaelistria
force-pushed
the
dom-with-javac
branch
from
11c94f4 to
99440ba
Compare
Another portion of the fix depended on addressing eclipse-jdt#4247, which is now resolved Signed-off-by: David Thompson <[email protected]>
There are other issues that arise when having a `module-info.java` in a Java 8 project, but this makes sure that we at least don't try to convert the AST nodes, which prevents an exception. Fixes eclipse-jdt#193 Signed-off-by: David Thompson <[email protected]>
Record components are often modeled as ILocalVariable, which might use different parent in a case or another. Instead of strictly checking for equal model element, we check that they are equivalent (name and position)
eg. after `|`
```java
public class CompleteInInstanceof {
public void myMethod() {
Object o = null;
boolean a = o instanceof RequiresDirective requires && useRequiresDirective(req|);
}
static class RequiresDirective {
private int a;
public RequiresDirective(int a) { this.a = a; }
int getA() { return a; }
}
public static boolean useRequiresDirective(RequiresDirective requiresDirective) {
return requiresDirective.getA() > 5;
}
}
```
Fixes eclipse-jdt#1593
Signed-off-by: David Thompson <[email protected]>
Completion tests are currently ignored as functional coverage for completion is already good and many tests are really failing for insignificant details (such as relevance which is overridden in UI anyway). So we skip the test to avoid noise and let dogfooding and actual usage feedback drive further improvements to completion. We may re-enable those tests later.
mickaelistria
force-pushed
the
restore-comparingsearch-level
branch
from
bf60323 to
20c5769
Compare
Author
|
Adds ~200 failures, let's wait a bit before merging it. |
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6dc0d95 to
25a5a08
Compare
robstryker
force-pushed
the
dom-with-javac
branch
3 times, most recently
from
b1b4e0e to
309f390
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
685330d to
959d707
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
2dbfcc7 to
6e1fd32
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
0b01689 to
87ead9e
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6d23874 to
c8f8d92
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
055e846 to
18452eb
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
411dfec to
ac3eb19
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
5738537 to
9962d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.