Verify method parameter types to return accuracy#1547

Open

mickaelistria wants to merge 1229 commits intoeclipse-jdtls:dom-with-javacfrom

mickaelistria:params

This pull request is big! We're only showing the most recent 250 commits

Commits on Jun 25, 2025

Expected type for SingleVariableDeclaration in CatchClause

datho7561
authored and
rgrunber
committed
Suggest keywords before the top level type

datho7561
authored and
rgrunber
committed
Completion for `case` keyword

datho7561
authored and
rgrunber
committed
Completion for break and yield in switch statements and expr

datho7561
authored and
rgrunber
committed
Keyword completion: differentiate between expressions and statements

datho7561
authored and
rgrunber
committed
Many keyword completion fixes

datho7561
authored and
rgrunber
committed
[DOM Search] - Fixes testParameterizedTypeSingleArgument01 and 6 others

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fix testDeclarationOfReferencedTypes05 and 1 others

Rob Stryker
authored and
rgrunber
committed
Fix CompletionContextTests0123 inside JavacConverter

Rob Stryker
authored and
rgrunber
committed
Mark malformed

Rob Stryker
authored and
rgrunber
committed
Keyword completion fixes for try/catch/finally and do-while

datho7561
authored and
rgrunber
committed
Another round of keyword completions

datho7561
authored and
rgrunber
committed
[DOM Search] implement matching on wildcards, extends, super, and other bugs

Rob Stryker
authored and
rgrunber
committed
Undo some changes in jdt.core that are no longer relevant

Rob Stryker
authored and
rgrunber
committed
Cache type hierarchy in `DOMCompletionUtil.findInSupers`

datho7561
authored and
rgrunber
committed
Improve "override method" completion

datho7561
authored and
rgrunber
committed
Hack to prevent OperationCanceledException from being propagated to logs

datho7561
authored and
rgrunber
committed
Small fix to CompletionEngines and ExplectedTypes

mickaelistria
authored and
rgrunber
committed
Primitive types can autobox to `java.lang.Object`

datho7561
authored and
rgrunber
committed
Prevent NPEs in completion tests

datho7561
authored and
rgrunber
committed
Lazily resolve DOMCompletionContext.getEnclosingElement()

mickaelistria
authored and
rgrunber
committed
Fixes testParameterizedType_Bug83713 - Fix bad binding key

Rob Stryker
authored and
rgrunber
committed
More error/NPE fixes in completion

datho7561
authored and
rgrunber
committed
Avoid calling getKey() too greedily

mickaelistria
authored and
rgrunber
committed
Add "since" 4.32 tag for Java 24 constants.
rgrunber
committed
Adjust based on javac library updates.

rgrunber
and
datho7561
committed
Set Java 24 requirement for org.eclipse.jdt.core.javac

mickaelistria
authored and
rgrunber
committed
Revert some changes in jdt.core to match upstream

datho7561
authored and
rgrunber
committed
Fix some JAVADOC_LINE offsets

mickaelistria
authored and
rgrunber
committed
Clean up / revert some unnecessary changes in jdt.core

Rob Stryker
authored and
rgrunber
committed
Use recovered type for erasure in javac bindings

datho7561
authored and
rgrunber
committed
Filter visibility on search match (do not open type to get modifiers)

mickaelistria
authored and
rgrunber
committed
Avoid NPE when trying to resolve type from key

mickaelistria
authored and
rgrunber
committed
Some updates for Javadoc markdown conversion to Java 24

mickaelistria
authored and
rgrunber
committed
Prevent NPE

mickaelistria
authored and
rgrunber
committed
Map more problems

mickaelistria
authored and
rgrunber
committed
Key for anonymous type declarations

datho7561
authored and
rgrunber
committed
Use SignatureUtils everywhere in DOMCompletionEngine

mickaelistria
authored and
rgrunber
committed
Fix insertion for enum constants

mickaelistria
authored and
rgrunber
committed
Fix relevance

mickaelistria
authored and
rgrunber
committed
[WIP] Handle `IAccessRules` in completion

datho7561
authored and
rgrunber
committed
Improvements for ExpectedTypes

mickaelistria
authored and
rgrunber
committed
Fix testLocalVariableDeclaration1 and 10+ others

Rob Stryker
authored and
rgrunber
committed
Lazily resolve whether variable is unique

mickaelistria
authored and
rgrunber
committed
Don't rely on getKey to ensure bindings are unique

mickaelistria
authored and
rgrunber
committed
Improve variableName proposals for collections

mickaelistria
authored and
rgrunber
committed
Stabilize some tests where ordering is important

mickaelistria
authored and
rgrunber
committed
Fix location for MemberRef without qualifier

mickaelistria
authored and
rgrunber
committed
Better separate source and bin in sourcepath/classpath

mickaelistria
authored and
rgrunber
committed
Complete on method name without expression

mickaelistria
authored and
rgrunber
committed
Do not fail on resolveBinding() when symbol has no matching .class

mickaelistria
authored and
rgrunber
committed
Always propose Object's methods

mickaelistria
authored and
rgrunber
committed
Improve perf for some completion based on index

mickaelistria
authored and
rgrunber
committed
Share Names

mickaelistria
authored and
rgrunber
committed
[DOM Search] Fix testStringParameterizedMultipleArguments01 and 02, 03, 04 and others

Rob Stryker
authored and
rgrunber
committed
Fix testStringNestedMultipleArguments02

Rob Stryker
authored and
rgrunber
committed
[DOM Search] check current package for non-imported missing types

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Parameterized types are not having source range replaced when unnecessarily qualified

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Various issues trying to match unresolved patterns

Rob Stryker
authored and
rgrunber
committed
Incorrect hover and content assist with lombok

snjeza
authored and
rgrunber
committed
Don't use not-upstream DOMCodeSelector.isGenerated()

mickaelistria
authored and
rgrunber
committed
Completion Perf: Delay `scrapeAccessibleBindings`

mickaelistria
authored and
rgrunber
committed
Ensure bindings are resolved before requesting import binding

mickaelistria
authored and
rgrunber
committed
Mark array types referenced in method @see reference as used

datho7561
authored and
rgrunber
committed
Map another two error messages

datho7561
authored and
rgrunber
committed
Skip running jdt.core tests without javac

datho7561
authored and
rgrunber
committed
Improve first parameter completion for method

datho7561
authored and
rgrunber
committed
Fix intersection bindings

datho7561
authored and
rgrunber
committed
Completing static member no longer inserts class name twice

datho7561
authored and
rgrunber
committed
Fix testStringNestedMultipleArguments05

Rob Stryker
authored and
rgrunber
committed
Fix testStringNestedSingleArgument01

Rob Stryker
authored and
rgrunber
committed
Fix one issue - unsure which

Rob Stryker
authored and
rgrunber
committed
Do not report imports for exact tests

Rob Stryker
authored and
rgrunber
committed
Fix testParameterizedArrayTypeMultipleArguments01 and 6 others

Rob Stryker
authored and
rgrunber
committed
Fix several regressions in JavaSearchGenericTypeEquivalentTests

Rob Stryker
authored and
rgrunber
committed
Reorg how validating type parameters works

Rob Stryker
authored and
rgrunber
committed
[DOM Search Tests] - Fixes 8 tests, add some support for exact search on type arguments

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fix 8 tests related to search queries with no type params when node qualifier has type params

Rob Stryker
authored and
rgrunber
committed
Fix testStringParameterizedMultipleArguments01

Rob Stryker
authored and
rgrunber
committed
Fix testStringParameterizedMultipleArguments02

Rob Stryker
authored and
rgrunber
committed
Set -Xproc:none when APT is disabled

mickaelistria
authored and
rgrunber
committed
Maybe fix semantic highlighting

datho7561
authored and
rgrunber
committed
[DOM Search] Fixes 4

Rob Stryker
authored and
rgrunber
committed
Fix ASTConverterAST8Test.test0049()/test0052()

snjeza
authored and
rgrunber
committed
Fix some qualification relevances

datho7561
authored and
rgrunber
committed
[DOM Search] Fixes several in JavaSearchGenericFieldTests

Rob Stryker
authored and
rgrunber
committed
Convert `@serial` javadoc tag

datho7561
authored and
rgrunber
committed
Completing enum sometimes double inserts the enum type name

datho7561
authored and
rgrunber
committed
Fix JavaSearchBugsTests.testBug83804_Type and 3 others

snjeza
authored and
rgrunber
committed
Resolve method name to method

mickaelistria
authored and
rgrunber
committed
Reformat all files in javac bundle to get rid of trailing spaces and other automatic changes

Rob Stryker
authored and
rgrunber
committed
Fixes #1370 - moving static method via refactor fails, DOMSearch

Rob Stryker
authored and
rgrunber
committed
Prevent error when accepting keyword completion before loop

datho7561
authored and
rgrunber
committed
Don't try to read symbol for JavacErrorMethodBinding.isVarargs

mickaelistria
authored and
rgrunber
committed
Fixes testMethodDeclarationsElementPatternMultipleParamArguments02

Rob Stryker
authored and
rgrunber
committed
Fix regressions

Rob Stryker
authored and
rgrunber
committed
Fixes testMethodReferencesStringPatternSingleParamArguments09 and others

Rob Stryker
authored and
rgrunber
committed
Fix ASTConverterTestAST8_2.test0602

snjeza
authored and
rgrunber
committed
Don't suggest keywords in an array initializer

datho7561
authored and
rgrunber
committed
Update GitHub action

mickaelistria
authored and
rgrunber
committed
Add workaround repo for repo.eclipse.org outage

mickaelistria
authored and
rgrunber
committed
Small fixes for record bindings

mickaelistria
authored and
rgrunber
committed
Map more problems

mickaelistria
authored and
rgrunber
committed
Try archiving JUnit reports in GitHub actions

mickaelistria
authored and
rgrunber
committed
More GH JUnit reporting

mickaelistria
authored and
rgrunber
committed
Cache and reuse symbols

mickaelistria
authored and
rgrunber
committed
Fixes symbol cache

mickaelistria
authored and
rgrunber
committed
More fixes to CachingClassSymbolClassReader

mickaelistria
authored and
rgrunber
committed
Only complete `default` inside annotations

mickaelistria
authored and
rgrunber
committed
Replace name instead of inserting when possible

mickaelistria
authored and
rgrunber
committed
Make ASTConverterMarkdownText more tolerant

mickaelistria
authored and
rgrunber
committed
Fix completion for `blah.| unrelatedMethod()`

mickaelistria
authored and
rgrunber
committed
Search skips visiting EnumConstantDeclaration name

mickaelistria
authored and
rgrunber
committed
Do not suggest keywords in empty block

datho7561
authored and
rgrunber
committed
Do not filter out types from file when completing field type

datho7561
authored and
rgrunber
committed
[DOMSearch] - Fixes testMethodReferencesStringPatternSingleParamArguments02

Rob Stryker
authored and
rgrunber
committed
[DOMSearch] Fixes testMethodReferencesStringPatternSingleParamArguments06

Rob Stryker
authored and
rgrunber
committed
Fixes testMethodReferencesElementPatternSingleTypeParameter04 and one other

Rob Stryker
authored and
rgrunber
committed
[JavacConverter] Imports are having static set twice, which breaks them

Rob Stryker
authored and
rgrunber
committed
NPE Check

Rob Stryker
authored and
rgrunber
committed
[DOMSearch] - Fix testMethodDeclarationsElementPatternMultipleParamArguments05 and one other

Rob Stryker
authored and
rgrunber
committed
Cleanup

Rob Stryker
authored and
rgrunber
committed
NPE

Rob Stryker
authored and
rgrunber
committed
[DOM Search] More method searches

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fixes 6 in JavaSearchGenericMethodExactTests

Rob Stryker
authored and
rgrunber
committed
Fix / Swallow 20 IllegalArgumentExceptions when comparing unresolved patterns

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Bandaid Fix for problem with wildcard key being completely wrong

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fix 12 - fixes isQuestionMark and ensures wildcard keys are parseable

Rob Stryker
authored and
rgrunber
committed
Fix some regressions

Rob Stryker
authored and
rgrunber
committed
NPE

Rob Stryker
authored and
rgrunber
committed
Fix test0264 in ASTConverter15JLS4Test

Rob Stryker
authored and
rgrunber
committed
Fix JavacAnnotationBinding.getAllMemberValuePairs()

mickaelistria
authored and
rgrunber
committed
Random Fixes in AST Converter tests

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fixes testParameterizedTypeMultipleArguments01 in equivalent tests

Rob Stryker
authored and
rgrunber
committed
[DOM Search] Fixes testParameterizedType_Bug83713

Rob Stryker
authored and
rgrunber
committed
Cleanup an unnecessary hard-coded signature

Rob Stryker
authored and
rgrunber
committed
Fixes testStringAnyStrings06 - name match with wildcard

Rob Stryker
authored and
rgrunber
committed
Improve JavacMethodBinding.isRaw()

mickaelistria
authored and
rgrunber
committed
[Search] Fix qualifiedSourceName

mickaelistria
authored and
rgrunber
committed
Revert "[Search] Fix qualifiedSourceName"

mickaelistria
authored and
rgrunber
committed
Fix an NPE in testMethodReferencesElementPatternMultipleTypeParameter03

Rob Stryker
authored and
rgrunber
committed
[Search] Compare simpleName when no qualifier is used

mickaelistria
authored and
rgrunber
committed
Allow parse() to return result even if some units are missing

mickaelistria
authored and
rgrunber
committed
Implement getDOMASTMethodBinding

mickaelistria
authored and
rgrunber
committed
Support for ConstructorInvocation in search

mickaelistria
authored and
rgrunber
committed
Fix type comparison in search

mickaelistria
authored and
rgrunber
committed
Fix for field references in field initializers

mickaelistria
authored and
rgrunber
committed
Fix test testMethodReferencesElementPatternMultipleTypeParameter02 - properly prefer weaker claim

Rob Stryker
authored and
rgrunber
committed
Fix an NPE in DOMMethodLocator

Rob Stryker
authored and
rgrunber
committed
[Search] Support OrPattern for DOM

mickaelistria
authored and
rgrunber
committed
[Search] Do not visit AnnotationTypeDeclaration name

mickaelistria
authored and
rgrunber
committed
Fix an IllegalArgumentException when calling member.getType()

Rob Stryker
authored and
rgrunber
committed
[Search] Honor `searchFor`

mickaelistria
authored and
rgrunber
committed
Mostly fix testSearchFieldInBinaryNoResolution - searches for field patterns should not return matches with non-field java elements

Rob Stryker
authored and
rgrunber
committed
fix search for binary types

mickaelistria
authored and
rgrunber
committed
Revert "Mostly fix testSearchFieldInBinaryNoResolution - searches for field p…"

mickaelistria
authored and
rgrunber
committed
Fix various NPEs

Rob Stryker
authored and
rgrunber
committed
[Search] Support reference to annotation member

mickaelistria
authored and
rgrunber
committed
Better support for searching MemberValuePair

mickaelistria
authored and
rgrunber
committed
[Search] Improve comparison of method return type

mickaelistria
authored and
rgrunber
committed
Improve getting level for arrays

mickaelistria
authored and
rgrunber
committed
[Search] Improve super type reference

mickaelistria
authored and
rgrunber
committed
[Search] Fix error when matching package declaration

mickaelistria
authored and
rgrunber
committed
Fix resolving JavaElement for binary types/methods

mickaelistria
authored and
rgrunber
committed
Match SingleMemberAnnotation value()

mickaelistria
authored and
rgrunber
committed
[Search] Improve filters when matching super-type

mickaelistria
authored and
rgrunber
committed
[Search] add support for StrigLiteral in SingleMemberAnnotation

mickaelistria
authored and
rgrunber
committed
[Search] Match type parameters from type declaration

mickaelistria
authored and
rgrunber
committed
Fixes testParameterizedArrayTypeSingleArgument04

Rob Stryker
authored and
rgrunber
committed
[Search] prefer returning actual member method (instead of similar one)

mickaelistria
authored and
rgrunber
committed
[Search] Add localElement to TypeParam ref match

mickaelistria
authored and
rgrunber
committed
Fix JavacTypeBinding.getErasure() for arrays

mickaelistria
authored and
rgrunber
committed
Fixes testStringNestedSingleArgument04

Rob Stryker
authored and
rgrunber
committed
Only add unresolved matches when there's some part that matches

Rob Stryker
authored and
rgrunber
committed
Fix some constructor completion tests

datho7561
authored and
rgrunber
committed
Fix JavacMethodBinding for varargs

mickaelistria
authored and
rgrunber
committed
Fix testTypeNestedSingleArgument03 and one or two others while preventing regressions

Rob Stryker
authored and
rgrunber
committed
Fix testBug549413_017 - use correct working copy resolver, and more

Rob Stryker
authored and
rgrunber
committed
Keep track of the .jar when processing binary type

mickaelistria
authored and
rgrunber
committed
Find SUPER_INVOCATION and flag them as expected

mickaelistria
authored and
rgrunber
committed
Fall back to search to find `IType` for a `JavacTypeBinding`

datho7561
authored and
rgrunber
committed
Using javac ASTParser outside of OSGi environment

snjeza
authored and
rgrunber
committed
Match MethodReference (by name)

mickaelistria
authored and
rgrunber
committed
Match methodReferences

mickaelistria
authored and
rgrunber
committed
Match inside binary files

mickaelistria
authored and
rgrunber
committed
Implement completion for modules in Javadoc

datho7561
authored and
rgrunber
committed
Address bug in javadoc type completion

datho7561
authored and
rgrunber
committed
Fix searching java element in initializer

mickaelistria
authored and
rgrunber
committed
Comment out 3 tests that keep killing my env

Rob Stryker
authored and
rgrunber
committed
Fixes testMethodReferencesElementPatternMultipleParamArguments01 - dom search with type args for receiver of method call

Rob Stryker
authored and
rgrunber
committed
Only suggest types in the `@throws` Javadoc

datho7561
authored and
rgrunber
committed
Javadoc tag completion for unparented comments

datho7561
authored and
rgrunber
committed
Improve completion for method references in Javadoc

datho7561
authored and
rgrunber
committed
Fix NPEs in package Javadoc completion

datho7561
authored and
rgrunber
committed
Fix context for Javadoc tag elements

datho7561
authored and
rgrunber
committed
Fix a completion case for `@link`

datho7561
authored and
rgrunber
committed
Complete types in javadoc text

datho7561
authored and
rgrunber
committed
Some more unparented comment completion fixes

datho7561
authored and
rgrunber
committed
Some more tag completion fixes

datho7561
authored and
rgrunber
committed
Refactor "find parent type binding"

datho7561
authored and
rgrunber
committed
Move true/false binding finder into utils class

datho7561
authored and
rgrunber
committed
Refining match method declaration when overriding generic super

mickaelistria
authored and
rgrunber
committed
Refining method matching, converting resolveLevel(MessageSend)

mickaelistria
authored and
rgrunber
committed
Refactor DOMCompletionEngine to use completeASTNodeName(...) methods

datho7561
authored and
rgrunber
committed
Improve SwitchCase completion, add break & continue completion

datho7561
authored and
rgrunber
committed
Properly set bindingIsDeclaration

mickaelistria
authored and
rgrunber
committed
Do not take return type into account when matching methods

mickaelistria
authored and
rgrunber
committed
Support for matching MethodRef

mickaelistria
authored and
rgrunber
committed
Match reference to implicit super-constructor

mickaelistria
authored and
rgrunber
committed
More support for SearchMatch.localElement

mickaelistria
authored and
rgrunber
committed
Respect ignored completion proposals

datho7561
authored and
rgrunber
committed
Match recovered types

mickaelistria
authored and
rgrunber
committed
Match recovered types (2)

mickaelistria
authored and
rgrunber
committed
Fix Javadoc tag replace range

datho7561
authored and
rgrunber
committed
Support read/write access info on variable/field match

mickaelistria
authored and
rgrunber
committed
Fix computation of mustResolve

mickaelistria
authored and
rgrunber
committed
Support otherElements in variable/field type declaration match

mickaelistria
authored and
rgrunber
committed
[DOM Search] modify tests to not compare match level for specific situations

robstryker
authored and
rgrunber
committed
[DOM Search] Fix some NPEs

robstryker
authored and
rgrunber
committed
Replace range for qualified type in a Javadoc

datho7561
authored and
rgrunber
committed
Fix testStringNestedSingleArgument03

robstryker
authored and
rgrunber
committed
Fix testMethodDeclarationsStringPatternMultipleParamArguments04

robstryker
authored and
rgrunber
committed
Fix regressions

robstryker
authored and
rgrunber
committed
Expected types for yield statement

datho7561
authored and
rgrunber
committed
Improve completion of nested types in Javadoc

datho7561
authored and
rgrunber
committed
Completion of variable before `this`

datho7561
authored and
rgrunber
committed
Fix missing new line in p2.inf

mickaelistria
authored and
rgrunber
committed
Multi variable declarations in same switch statement

mickaelistria
authored and
rgrunber
committed
Fix qualifiedName for local types

mickaelistria
authored and
rgrunber
committed
setEscapedValue for CharacterLiteral

mickaelistria
authored and
rgrunber
committed
Return null declaring method for fields

mickaelistria
authored and
rgrunber
committed
Properly set binding flag on AST

mickaelistria
authored and
rgrunber
committed
Match alternative message from Javac for missing method

mickaelistria
authored and
rgrunber
committed
Fix potential NPE in DOMMethodLocator.resolveLevel()

mickaelistria
authored and
rgrunber
committed
Filter field/method matches according to fineGrain

mickaelistria
authored and
rgrunber
committed
Disable irrelevant check failing because of serialVersionUUID

mickaelistria
authored and
rgrunber
committed
Support searching primitive types

mickaelistria
authored and
rgrunber
committed
Partial support for fineGrain references

mickaelistria
authored and
rgrunber
committed
Add missing visited types for search

mickaelistria
authored and
rgrunber
committed
skip type params for fineGrain patterns

mickaelistria
authored and
rgrunber
committed
Fix 6 issues in DOMMethodLocator

robstryker
authored and
rgrunber
committed
Comment out some debugging output

robstryker
authored and
rgrunber
committed
Fix bad method signature

datho7561
authored and
rgrunber
committed
Update versions in parent POM references for javac bundle
rgrunber
committed

Verify method parameter types to return accuracy#1547mickaelistria wants to merge 1229 commits intoeclipse-jdtls:dom-with-javaceclipse-jdtls/eclipse-jdt-core-incubator:dom-with-javacfrom mickaelistria:paramsmickaelistria/eclipse.jdt.core:paramsCopy head branch name to clipboard

Commits

Commits on Jun 25, 2025

Verify method parameter types to return accuracy#1547
mickaelistria wants to merge 1229 commits intoeclipse-jdtls:dom-with-javacfrom
mickaelistria:params