Recovered code select #1552
Open
Recovered code select #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er bugs Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Speeds up completion of types significantly, since the type hierarchy of `java.lang.Exception` is only created once every completion invocation. Signed-off-by: David Thompson <[email protected]>
- Handle qualifying types referenced in the method declaration - eg. do not qualify imported types - eg. do not qualify types from the same package - eg. do not qualify inner classes nor inherited inner classes - Fix parameter names - get them from the `IMethod`, which has more accurate - Handle completion in anonymous classes - Do not suggest overriding a method that's already overriden Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
Should improve a couple tests + Added a Timer utility class to help profiling
(for expected types purposes) Signed-off-by: David Thompson <[email protected]>
- Prevent NPE when completing name of the last parameter in a method
declaration
- This uses the existing "suggest a name for this variable" logic
- Prevent various NPEs when completing the first parameter of a
parameterized type
- eg.
```java
List<| asdf = new ArrayList<>();
```
- move private check before deprecated check to avoid NPE trying to
access the `IMethod` for a private JDK class member.
(I think the root cause is that the private method doesn't exist in the
stubbed jar, so we can't access the associated `IMethod`, but it does
exist in javac's internal bindings, since javac has access to the real
JDK class)
- when completing throws clause, add null checks when accessing the
return type and name to compute the scanning index
- constructors don't have a return type node, and an incomplete method
declaration might not have a name
- replace a use of "Ljava/lang/Object;" with the constant from KeyUtils
Should fix 5 cases, and switch several test errors over to failures.
Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
- handle completing package-qualified method parameter type - do not suggest overriding existing or declaring new methods in annotation type declarations - when building override method completions, if the `IMethod` of a given method binding cannot be found, use the parameter names from the bindings instead - prevent NPE when attempting to suggest completion for a method with an incomplete parameter type Signed-off-by: David Thompson <[email protected]>
getKey can be very expensive, so we should only have it computed on demand. This saves ~30% when executing completion tests with Javac.
- Add api filter for JLS_Latest Signed-off-by: Roland Grunberg <[email protected]>
Signed-off-by: Roland Grunberg <[email protected]> Co-Authored-by: David Thompson <[email protected]>
- Undo `@since` and cosmetic changes - Remove changes from CompletionEngine Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Should fix at least one test failure. Signed-off-by: David Thompson <[email protected]>
Fixes eclipse-jdtls#986 Fixes eclipse-jdtls#1184 Fixes eclipse-jdtls#1217 Fixes eclipse-jdtls#1233 Fixes eclipse-jdtls#1234 Fixes eclipse-jdtls#1250 Fixes eclipse-jdtls#1328
- should fix one completion test Signed-off-by: David Thompson <[email protected]>
* for enumConstants * for types
- hide types from other projects that are marked as inaccessible from completion (unless the appropriate settings to allow them to be completed are enabled) - relevance numbers for those types TODO: - [ ] clean up the code, add comments, etc. Signed-off-by: David Thompson <[email protected]>
+ improve rule for generic methods
mickaelistria
force-pushed
the
recoveredCodeSelect
branch
from
3acbcd2 to
cb32599
Compare
…f other java elements in type matches Signed-off-by: Rob Stryker <[email protected]>
Better resolve pattern binding
Use constructorType, which keeps ref of type parameters
Should fix 2 Signed-off-by: David Thompson <[email protected]>
mickaelistria
force-pushed
the
recoveredCodeSelect
branch
from
cb32599 to
0962f3a
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
73d28b4 to
aa8f401
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
4082278 to
ebc593c
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
11c94f4 to
99440ba
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6dc0d95 to
25a5a08
Compare
robstryker
force-pushed
the
dom-with-javac
branch
3 times, most recently
from
b1b4e0e to
309f390
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
685330d to
959d707
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
2dbfcc7 to
6e1fd32
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
0b01689 to
87ead9e
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
6d23874 to
c8f8d92
Compare
robstryker
force-pushed
the
dom-with-javac
branch
from
055e846 to
18452eb
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
411dfec to
ac3eb19
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
5738537 to
9962d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.